From: naruse@... Date: 2017-09-25T17:04:47+00:00 Subject: [ruby-core:83003] [Ruby trunk Bug#13940][Rejected] em-http-request (HttpConnectionOptions) over-write :sni_hostname if provided Issue #13940 has been updated by naruse (Yui NARUSE). Status changed from Open to Rejected We CRuby project doesn't handle em-http-request. Could you ask on https://github.com/igrigorik/em-http-request ? ---------------------------------------- Bug #13940: em-http-request (HttpConnectionOptions) over-write :sni_hostname if provided https://bugs.ruby-lang.org/issues/13940#change-66912 * Author: steve.misky (Stephen Misk) * Status: Rejected * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin16] * Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN ---------------------------------------- Breaking change introduced in 1.1.4 http_connnection_options.rb:23 @tls[:sni_hostname] = ori.host This OVER-write the sni_hostname value which MAY have been passed in. # Suggested Change to SET sni_hostname ONLY IF not provided @tls[:sni_hostname] ||= uri.host -- https://bugs.ruby-lang.org/ Unsubscribe: