[ruby-core:83001] [Ruby trunk Bug#13940] em-http-request (HttpConnectionOptions) over-write :sni_hostname if provided

From: smiskowitz@...
Date: 2017-09-25 16:55:07 UTC
List: ruby-core #83001
Issue #13940 has been reported by steve.misky (Stephen Misk).

----------------------------------------
Bug #13940: em-http-request (HttpConnectionOptions) over-write :sni_hostname if provided
https://bugs.ruby-lang.org/issues/13940

* Author: steve.misky (Stephen Misk)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin16]
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
Breaking change introduced in 1.1.4

http_connnection_options.rb:23
@tls[:sni_hostname] = ori.host

This OVER-write the sni_hostname value which MAY have been passed in.
# Suggested Change to SET sni_hostname ONLY IF not provided
@tls[:sni_hostname] ||= uri.host



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next