[#71931] [Ruby trunk - Feature #11786] [Open] [PATCH] micro-optimize case dispatch even harder — normalperson@...

Issue #11786 has been reported by Eric Wong.

9 messages 2015/12/08

[ruby-core:72399] [Ruby trunk - Bug #11844] Please update unicode-licensed files (license issue)

From: duerst@...
Date: 2015-12-20 02:20:54 UTC
List: ruby-core #72399
Issue #11844 has been updated by Martin D=C3=BCrst.


Christian Hofstaedtler wrote:
> Various files in enc/trans are old copies of Unicode.org files that forbi=
d (re-)distribution. AFAICT, Unicode, Inc. has published newer versions of =
these files to fix this issue.

It looks like you have problems with the following text, e.g. in enc/trans/=
JIS/JISX0212%UCS.src:

###
#	Recipient is granted the right to make copies in any form for
#	internal distribution and to freely use the information supplied
#	in the creation of products supporting Unicode.  Unicode, Inc.
#	specifically excludes the right to re-distribute this file directly
#	to third parties or other organizations whether for profit or not.
###

However, this doesn't create any problems. We explicitly use the informatio=
n to create products=20
(namely Ruby) supporting Unicode. We also don't distribute the file directl=
y; there is an implementation-specific header at the start of the file, and=
 another implementation-specific line at the end. Also, please note that at=
 least some files (e.g. UCS%JISX0212.src) are changed much more, as the ord=
er is no longer the one claimed in the header ("The entries are in JIS X 02=
12 order"). In addition, each line comes with a '=3D' between the codepoint=
s being converted, whereas http://www.unicode.org/Public/MAPPINGS/OBSOLETE/=
EASTASIA/JIS/JIS0212.TXT only has a tab between the codepoints, but comment=
s on each line.

So at least for these files, what we do doesn't conflict with the condition=
s on these files at all. (Even if it did, the fact that Unicode changed the=
 copyright to be more liberal is a strong indication that they wouldn't wan=
t to claim any violation anymore.)

> New versions could possibly be found on http://www.unicode.org/Public/MAP=
PINGS/OBSOLETE/EASTASIA/JIS/ and elsewhere under http://www.unicode.org/Pub=
lic/

I haven't checked whether they are available for all of our data. But that'=
s not the problem. The problem is that our files are already changed quite =
a bit, and it would be difficult to make sure we apply exactly the same cha=
nges that we applied to the original files.

I think if this is really a problem for you (I hope that after the explanat=
ion above it isn't anymore), then we should think about modifying the heade=
r, not the data, to reduce the danger of regressions.


> ext/json/generator/generator.c also has a restrictive Unicode, Inc. licen=
se blurb. Please fix this as well.

Restrictive? Have you actually read the blurb? Here's what it says:

 * Limitations on Rights to Redistribute This Code
 *
 * Unicode, Inc. hereby grants the right to freely use the information
 * supplied in this file in the creation of products supporting the
 * Unicode Standard, and to make copies of this file in any form
 * for internal or external distribution as long as this notice
 * remains attached.

So it's okay to make copies of that file in any form for internal or extern=
al distribution.
But it's not okay to remove (or change) the copyright notice. So we are exa=
ctly in compliance, and you shouldn't have any problems whatsoever with it.


----------------------------------------
Bug #11844: Please update unicode-licensed files (license issue)
https://bugs.ruby-lang.org/issues/11844#change-55685

* Author: Christian Hofstaedtler
* Status: Open
* Priority: Normal
* Assignee:=20
* ruby -v: 2.2.3
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
Various files in enc/trans are old copies of Unicode.org files that forbid =
(re-)distribution. AFAICT, Unicode, Inc. has published newer versions of th=
ese files to fix this issue.
New versions could possibly be found on http://www.unicode.org/Public/MAPPI=
NGS/OBSOLETE/EASTASIA/JIS/ and elsewhere under http://www.unicode.org/Publi=
c/

ext/json/generator/generator.c also has a restrictive Unicode, Inc. license=
 blurb. Please fix this as well.




--=20
https://bugs.ruby-lang.org/

In This Thread

Prev Next