[#71815] [Ruby trunk - Bug #11768] [Open] Add a polymorphic inline cache — tenderlove@...
Issue #11768 has been reported by Aaron Patterson.
6 messages
2015/12/03
[#71819] Re: [Ruby trunk - Bug #11768] [Open] Add a polymorphic inline cache
— Eric Wong <normalperson@...>
2015/12/03
tenderlove@ruby-lang.org wrote:
[#71821] Re: [Ruby trunk - Bug #11768] [Open] Add a polymorphic inline cache
— Aaron Patterson <tenderlove@...>
2015/12/03
On Thu, Dec 03, 2015 at 10:51:08PM +0000, Eric Wong wrote:
[#71824] Re: [Ruby trunk - Bug #11768] [Open] Add a polymorphic inline cache
— Eric Wong <normalperson@...>
2015/12/04
Aaron Patterson <tenderlove@ruby-lang.org> wrote:
[#71818] [Ruby trunk - Feature #11769] [Open] optimize case / when for `nil` — tenderlove@...
Issue #11769 has been reported by Aaron Patterson.
4 messages
2015/12/03
[#71825] Re: [Ruby trunk - Feature #11769] [Open] optimize case / when for `nil`
— Eric Wong <normalperson@...>
2015/12/04
tenderlove@ruby-lang.org wrote:
[#71931] [Ruby trunk - Feature #11786] [Open] [PATCH] micro-optimize case dispatch even harder — normalperson@...
Issue #11786 has been reported by Eric Wong.
9 messages
2015/12/08
[#71932] Re: [Ruby trunk - Feature #11786] [Open] [PATCH] micro-optimize case dispatch even harder
— Eric Wong <normalperson@...>
2015/12/08
Oops, I forgot to free the table when iseq is destroyed :x
[#71934] Re: [Ruby trunk - Feature #11786] [Open] [PATCH] micro-optimize case dispatch even harder
— SASADA Koichi <ko1@...>
2015/12/08
On 2015/12/08 12:43, Eric Wong wrote:
[#71936] Re: [Ruby trunk - Feature #11786] [Open] [PATCH] micro-optimize case dispatch even harder
— Eric Wong <normalperson@...>
2015/12/08
SASADA Koichi <ko1@atdot.net> wrote:
[#71938] Re: [Ruby trunk - Feature #11786] [Open] [PATCH] micro-optimize case dispatch even harder
— SASADA Koichi <ko1@...>
2015/12/08
On 2015/12/08 13:53, Eric Wong wrote:
[#72028] [Ruby trunk - Feature #11405] [Assigned] [PATCH] hash.c: minor speedups to int/fixnum keys — mame@...
Issue #11405 has been updated by Yusuke Endoh.
5 messages
2015/12/10
[#72040] Re: [Ruby trunk - Feature #11405] [Assigned] [PATCH] hash.c: minor speedups to int/fixnum keys
— Eric Wong <normalperson@...>
2015/12/10
mame@ruby-lang.org wrote:
[#72045] Ruby 2.3.0-preview2 Released — "NARUSE, Yui" <naruse@...>
We are pleased to announce the release of Ruby 2.3.0-preview2.
10 messages
2015/12/11
[#72047] Re: Ruby 2.3.0-preview2 Released
— SASADA Koichi <ko1@...>
2015/12/11
Please add your optimizations before RC1.
[#72054] Re: Ruby 2.3.0-preview2 Released
— Eric Wong <normalperson@...>
2015/12/11
SASADA Koichi <ko1@atdot.net> wrote:
[#72436] Re: Ruby 2.3.0-preview2 Released
— SASADA Koichi <ko1@...>
2015/12/22
On 2015/12/11 18:06, Eric Wong wrote:
[#72440] Re: Ruby 2.3.0-preview2 Released
— Eric Wong <normalperson@...>
2015/12/22
SASADA Koichi <ko1@atdot.net> wrote:
[#72069] [Ruby trunk - Feature #11405] [PATCH] hash.c: minor speedups to int/fixnum keys — mame@...
Issue #11405 has been updated by Yusuke Endoh.
3 messages
2015/12/12
[#72115] Re: [ruby-cvs:60264] duerst:r53112 (trunk): * enc/ebcdic.h: new dummy encoding EBCDIC-US — "U.NAKAMURA" <usa@...>
Hi,
7 messages
2015/12/14
[#72124] Re: [ruby-cvs:60264] duerst:r53112 (trunk): * enc/ebcdic.h: new dummy encoding EBCDIC-US
— Martin J. Dürst <duerst@...>
2015/12/14
On 2015/12/14 22:34, U.NAKAMURA wrote:
[#72125] Re: [ruby-cvs:60264] duerst:r53112 (trunk): * enc/ebcdic.h: new dummy encoding EBCDIC-US
— "U.NAKAMURA" <usa@...>
2015/12/15
Hi,
[ruby-core:72378] [Ruby trunk - Bug #11842] r53123 breaks some gems which use erb
From:
takashikkbn@...
Date:
2015-12-19 12:26:35 UTC
List:
ruby-core #72378
Issue #11842 has been updated by Takashi Kokubun.
I saw rails's build is also broken due to thor. These are all I know for now.
By the way, since my patch to thor https://github.com/erikhuda/thor/pull/512 was merged, now thor master has no problem about this.
----------------------------------------
Bug #11842: r53123 breaks some gems which use erb
https://bugs.ruby-lang.org/issues/11842#change-55669
* Author: Kaneko Yuichiro
* Status: Open
* Priority: Normal
* Assignee:
* ruby -v: ruby 2.3.0dev (trunk 53153) [x86_64-darwin14]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
r53123 breaks some gems which use erb.
Thor gem for example.
They set an instance variable `"@output_buffer"` to 4th argument (`eoutvar`) of `ERB.new` ([here](https://github.com/erikhuda/thor/blob/f0c2166534e122636f5ce04d61885736ef605617/lib/thor/actions/file_manipulation.rb#L116)).
And change this instance variable from outside erb ([here](https://github.com/erikhuda/thor/blob/f0c2166534e122636f5ce04d61885736ef605617/lib/thor/actions/file_manipulation.rb#L308)).
[Example code of erb](https://github.com/ruby/ruby/blob/ec7a964dca57821d2d7a36f168c2355a46a76ca2/lib/erb.rb#L751) shows this usage of `eoutvar`.
I think we should revert r53123 and add a test case for this usage.
```
Failures:
1) Thor::Actions#template allows using block helpers in the template
Failure/Error: concat(result.strip + " world!")
NoMethodError:
undefined method `strip' for ["Hello\n"]:Array
# ./spec/fixtures/group.thor:58:in `world'
# (erb):1:in `template'
# ./lib/thor/actions/file_manipulation.rb:116:in `block in template'
# ./lib/thor/actions/create_file.rb:53:in `render'
# ./lib/thor/actions/create_file.rb:62:in `block (2 levels) in invoke!'
# ./lib/thor/actions/create_file.rb:62:in `open'
# ./lib/thor/actions/create_file.rb:62:in `block in invoke!'
# ./lib/thor/actions/empty_directory.rb:116:in `invoke_with_conflict_check'
# ./lib/thor/actions/create_file.rb:60:in `invoke!'
# ./lib/thor/actions.rb:94:in `action'
# ./lib/thor/actions/create_file.rb:25:in `create_file'
# ./lib/thor/actions/file_manipulation.rb:115:in `template'
# ./spec/actions/file_manipulation_spec.rb:11:in `block in action'
# ./spec/helper.rb:55:in `capture'
# ./spec/actions/file_manipulation_spec.rb:11:in `action'
# ./spec/actions/file_manipulation_spec.rb:160:in `block (3 levels) in <top (required)>'
```
--
https://bugs.ruby-lang.org/