From: Eric Wong Date: 2015-12-16T07:22:46+00:00 Subject: [ruby-core:72177] Re: [Ruby trunk - Feature #11806] [PATCH] IO#advise should not raise Errno::ENOSYS naruse@airemix.jp wrote: > I don't know fadvise well, > > By this change an application lose any way of getting the result of posix_fadvise. > Is it really sufficient? I think so. > For example how about returning errno as the return value instead of returning always nil? Maybe, but on the other hand, I doubt really cares that much. They will also need to know exactly what kernel they're running and what it does with fadvise. > (it is also OK that keep returning nil until someone request to change) There is no guarantee a kernel does anything with it. Anybody checking it is probably wasting their time... We already return nil unconditionally on systems w/o fadvise at build time. > Anyway could you add a description to NEWS? Done, r53149