From: Joseph Jones <joeyi5216@...>
Date: 2015-12-17T21:13:14-07:00
Subject: [ruby-core:72337] Re: [ruby-cvs:60187] nobu:r53034 (trunk): test_io.rb: fix IO#advise on aarch64-linux

--567387da_9daf632_16c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Joseph Jones liked your message with Boxer. On December 11, 2015 at 00:48=
:34 MST, Eric Wong <normalperson=40yhbt.net> wrote:nobu=40ruby-lang.org w=
rote:> New Revision: 53034> > http://svn.ruby-lang.org/cgi-bin/viewvc.cgi=
=3Fview=3Drevision&revision=3D53034> > Log:> test=5Fio.rb: fix IO=23advis=
e on aarch64-linux> > * test/ruby/test=5Fio.rb (test=5Fadvise, test=5Fadv=
ise=5Fpipe): fadvise on> aarch64-linux returns ESYS.How about we hide ENO=
SYS from the user=3FIO=23advise is already a no-op on systems where posix=
=5Ffadviseis non-existent at build time.--- a/io.c+++ b/io.c=40=40 -8586,=
7 +8586,7 =40=40 do=5Fio=5Fadvise(rb=5Fio=5Ft *fptr, VALUE advice, off=5F=
t offset, off=5Ft len) ias.len =3D len;  rv =3D (int)rb=5Fthread=5Fio=5Fb=
locking=5Fregion(io=5Fadvise=5Finternal, &ias, fptr->fd);- if (rv) =7B+ i=
f (rv && rv =21=3D ENOSYS) =7B /* posix=5Ffadvise(2) doesn't set errno. O=
n success it returns 0; otherwise it returns the error code. */ VALUE mes=
sage =3D rb=5Fsprintf(=22%=22PRIsVALUE=22 =22     
--567387da_9daf632_16c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<html><body><div>Joseph Jones liked your message with <a href=3D=22http:/=
/bxr.io/PBIqo=22>Boxer</a>.</div><br/><br/><div><div class=3D=22quote=22>=
On December 11, 2015 at 00:48:34 MST, Eric Wong &lt;normalperson=40yhbt.n=
et&gt; wrote:<br/><blockquote type=3D=22cite=22 style=3D=22border-left-st=
yle:solid;border-width:1px;margin-left:0px;padding-left:10px;=22>nobu=40r=
uby-lang.org wrote:<br />>   New Revision: 53034<br />> <br />>   http://=
svn.ruby-lang.org/cgi-bin/viewvc.cgi=3Fview=3Drevision&revision=3D53034<b=
r />> <br />>   Log:<br />>     test=5Fio.rb: fix IO=23advise on aarch64-=
linux<br />>     <br />>     * test/ruby/test=5Fio.rb (test=5Fadvise, tes=
t=5Fadvise=5Fpipe): fadvise on<br />>       aarch64-linux returns ESYS.<b=
r /><br />How about we hide ENOSYS from the user=3F<br /><br />IO=23advis=
e is already a no-op on systems where posix=5Ffadvise<br />is non-existen=
t at build time.<br /><br />--- a/io.c<br />+++ b/io.c<br />=40=40 -8586,=
7 +8586,7 =40=40 do=5Fio=5Fadvise(rb=5Fio=5Ft *fptr, VALUE advice, off=5F=
t offset, off=5Ft len)<br />     ias.len    =3D len;<br /> <br />     rv =
=3D (int)rb=5Fthread=5Fio=5Fblocking=5Fregion(io=5Fadvise=5Finternal, &ia=
s, fptr->fd);<br />-    if (rv) =7B<br />+    if (rv && rv =21=3D ENOSYS)=
 =7B<br /> 	/* posix=5Ffadvise(2) doesn't set errno. On success it return=
s 0; otherwise<br /> 	   it returns the error code. */<br /> 	VALUE messa=
ge =3D rb=5Fsprintf(=22%=22PRIsVALUE=22 =22<br /></blockquote></div></div=
></body></html>
--567387da_9daf632_16c--