[#65451] [ruby-trunk - Feature #10333] [PATCH 3/1] optimize: "yoda literal" == string — ko1@...

Issue #10333 has been updated by Koichi Sasada.

9 messages 2014/10/07

[ruby-core:65556] Re: [ruby-trunk - Feature #8543] rb_iseq_load

From: Eric Wong <normalperson@...>
Date: 2014-10-09 07:44:48 UTC
List: ruby-core #65556
billk@cts.com wrote:
> Sorry to be the squeaky wheel, but I was wondering if there still
> might be a chance to look into this before 2.2 is released?

Not speaking for the rest of ruby-core, but I welcome occasional
reminders like these :)

> I attempted a `git bisect` this evening in the hope of narrowing
> down where the iseq.load problems began -- however I ran into a
> problem of being unable to build ruby-trunk prior to this patch:
> 
> commit 434826c0e9d3e3b48d99a39b7ad7626a6f1ae2eb
> Author: kazu <kazu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>
> Date:   Wed Jul 31 13:01:57 2013 +0000
> 
>     * parse.y: fix build error with bison-3.0.
> 
> And unfortunately the iseq.load problem already existed by that
> point.

Thanks for that data point, it was before I started mucking with iseq.
Can you try installing/running an older bison?

> (I wonder how best to proceed with the bisect.  I suppose one
> could write a script to attempt to apply the parse.y patch at
> each stage...)

Yes.  "git bisect run" is awesome for scripting these things.

In This Thread