[#65451] [ruby-trunk - Feature #10333] [PATCH 3/1] optimize: "yoda literal" == string — ko1@...

Issue #10333 has been updated by Koichi Sasada.

9 messages 2014/10/07

[ruby-core:65407] [ruby-trunk - Bug #10324] [Closed] [PATCH] do not link openssl to ext/digest/xxx when using --with-bundled-xxx

From: nobu@...
Date: 2014-10-05 02:04:10 UTC
List: ruby-core #65407
Issue #10324 has been updated by Nobuyoshi Nakada.

Status changed from Open to Closed
% Done changed from 0 to 100

Applied in changeset r47802.

----------
digest/*/extconf.rb: do not link openssl when using bundled

* ext/digest/{md5,rmd160,sha1,sha2}/extconf.rb: configure OpenSSL
  only if bundled libraries is not used, so that OpenSSL is not
  linked unnecessarily.  [ruby-core:65404] [Bug #10324]

----------------------------------------
Bug #10324: [PATCH] do not link openssl to ext/digest/xxx when using --with-bundled-xxx
https://bugs.ruby-lang.org/issues/10324#change-49201

* Author: Luiz Angelo Daros de Luca
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: ext
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.3p242 (2014-09-19 revision 47630) [i486-linux-gnu]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
Hello,

Ruby uses bundled digest implemetation when openssl is not avaiable. I also can select them using
configure option --with-bundled-xxx. However, even using it, openssl is still linked to ext/digest/<hash>/<hash>.so

In extconf.rb, dir_config and pkg_config are called before the with_config is tested.
So, dir_config or pkg_config (sorry for my ignorance) adds openssl to be linked.

This patch tests for with-bundled before checking/selecting openssl.
It depends on the patch from bug #10252

As I'm no extconf expert, maybe there is a much better way to achieve the same result.


---Files--------------------------------
004-digest_dont-link-ssl-if-not-needed.patch (3.49 KB)


-- 
https://bugs.ruby-lang.org/

In This Thread

Prev Next