[#54738] [ruby-trunk - Bug #8358][Open] TestSprintf#test_float test failuer on mingw32 — "phasis68 (Heesob Park)" <phasis@...>

36 messages 2013/05/02

[#54749] [ruby-trunk - Feature #8361][Open] Alternative syntax for block parameter — "alexeymuranov (Alexey Muranov)" <redmine@...>

12 messages 2013/05/02

[#54798] [ruby-trunk - Bug #8370][Open] Constants MAX_MULTIPART_LENGTH in cgi\core.rb — "xibbar (Takeyuki FUJIOKA)" <xibbar@...>

17 messages 2013/05/05

[#54850] [ruby-trunk - Feature #8377][Open] Deprecate :: for method calls in 2.1 — "charliesome (Charlie Somerville)" <charliesome@...>

27 messages 2013/05/07

[#54881] [ruby-trunk - Bug #8384][Open] Cannot build ruby against OpenSSL build with "no-ec2m" — "vo.x (Vit Ondruch)" <v.ondruch@...>

16 messages 2013/05/09

[#54921] [ruby-trunk - Bug #8393][Open] A class who's parent class is in a module can go wrong if files are required in the wrong order — "eLobato (Daniel Lobato Garcia)" <elobatocs@...>

15 messages 2013/05/12

[#54939] [ruby-trunk - Bug #8399][Open] Remove usage of RARRAY_PTR in C extensions when not needed — "dbussink (Dirkjan Bussink)" <d.bussink@...>

32 messages 2013/05/12

[#55053] [ruby-trunk - Feature #8426][Open] Implement class hierarchy method caching — "charliesome (Charlie Somerville)" <charliesome@...>

21 messages 2013/05/19

[#55096] [ruby-trunk - Feature #8430][Open] Rational number literal — "mrkn (Kenta Murata)" <muraken@...>

28 messages 2013/05/21

[#55197] [ruby-trunk - Feature #8461][Open] Easy way to disable certificate checking in XMLRPC::Client — "herwinw (Herwin Weststrate)" <herwin@...>

11 messages 2013/05/29

[ruby-core:54924] Re: [ruby-changes:28599] hsbt:r40651 (trunk): fixed wrong document for Socket.tcp by @lann [fix GH-302]

From: Tanaka Akira <akr@...>
Date: 2013-05-12 01:56:42 UTC
List: ruby-core #54924
2013/5/12 hsbt <ko1@atdot.net>:
> hsbt    2013-05-12 10:44:06 +0900 (Sun, 12 May 2013)
>
>   New Revision: 40651
>
>   http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=40651
>
>   Log:
>     fixed wrong document for Socket.tcp by @lann [fix GH-302]
>
>   Modified files:
>     trunk/ext/socket/lib/socket.rb
>
> Index: ext/socket/lib/socket.rb
> ===================================================================
> --- ext/socket/lib/socket.rb    (revision 40650)
> +++ ext/socket/lib/socket.rb    (revision 40651)
> @@ -288,11 +288,6 @@ class Socket < BasicSocket https://github.com/ruby/ruby/blob/trunk/ext/socket/lib/socket.rb#L288
>    # The value of the block is returned.
>    # The socket is closed when this method returns.
>    #
> -  # The optional last argument _opts_ is options represented by a hash.
> -  # _opts_ may have following options:
> -  #
> -  # [:timeout] specify the timeout in seconds.
> -  #
>    # If no block is given, the socket is returned.
>    #
>    #   Socket.tcp("www.ruby-lang.org", 80) {|sock|

Removing the option description is not a good fix.

https://github.com/ruby/ruby/pull/302 describes as
"Socket.tcp supports a :connect_timeout opt but not :timeout."
-- 
Tanaka Akira

In This Thread

Prev Next