From: "mame (Yusuke Endoh)" <mame@...>
Date: 2012-04-23T22:41:35+09:00
Subject: [ruby-core:44551] [ruby-trunk - Feature #4598] Net::SMTP should raise more helpfully when mail can't send


Issue #4598 has been updated by mame (Yusuke Endoh).

Assignee changed from aamine (Minero Aoki) to mame (Yusuke Endoh)

Looks good.  At least, I think the fix is benign.
I'll commit it unless there is objection.

-- 
Yusuke Endoh <mame@tsg.ne.jp>
----------------------------------------
Feature #4598: Net::SMTP should raise more helpfully when mail can't send
https://bugs.ruby-lang.org/issues/4598#change-26103

Author: tkieft (Tyler Kieft)
Status: Assigned
Priority: Normal
Assignee: mame (Yusuke Endoh)
Category: lib
Target version: 


=begin
Net::SMTP, in function check_continue? (line 952) raises "could not get 3xx (STATUS_CODE)" when it receives anything except a 300-399 (continue) code from the SMTP server.  This is *extremely* unhelpful for users of the library, as the mail server usually sends an explanatory message that isn't passed along.

Suggest that it should be something like:

 def check_continue(res)
   unless res.continue?
     raise SMTPUnknownError, "could not get 3xx (#{res.status}: #{res.string})"
   end
 end

=end



-- 
http://bugs.ruby-lang.org/