From: Nobuyoshi Nakada <nobu@...>
Date: 2012-04-05T17:13:40+09:00
Subject: [ruby-core:44142] Re: [ruby-trunk - Bug #6183] Enumerator::Lazy performance issue

Hi,

(12/04/04 20:59), Yusuke Endoh wrote:
> I glanced your patch.  It will degrade functional modularity
> in enumerator.c.  Currently, it not so big problem because
> it only implements #map and #select.  But I guess implementing
> other methods, especially, #cycle and #zip, will make some
> functions (process_element and lazy_iterator_block) complex
> and hard to maintain.

Agree.

Naturally, this approach which chains lazy enumerator processes
directly should be faster than current one.  So I want to see this
being merged in an extensible way.

> Thus, until you create the final patch, it is hard to say
> whether we can import your patch or not.

And, do not comment out existing code with //.  It unnecessarily
increases noise in the patch.

-- 
Nobu Nakada