[ruby-core:23211] [Bug #1367] flatten(0) is not consistent with flatten(), flatten(1), etc.

Issue #1367 has been updated by Paul Lewis.


As a pro-fix argument consider what happens when the code using flatten has a dynamic depth value.  So rather than:

x = a.flatten(0)

It's something like:

x = a.flatten(depth)

To ensure that this code behaviour predictably (without this fixed) it becomes necessary to treat 0 as a special case:

depth = ???
x = (depth != 0 ? a.flatten() : a.clone())

As it works at the moment I think it violates the principle of least surprise.
http://en.wikipedia.org/wiki/Principle_of_least_surprise
----------------------------------------
http://redmine.ruby-lang.org/issues/show/1367

----------------------------------------
http://redmine.ruby-lang.org