From: Eero Saynatkari <ruby-ml@...>
Date: 2009-05-16T10:34:45+09:00
Subject: [ruby-core:23474] Re: [Bug #1382] inline functions ought to be static

Excerpts from Luiz Angelo Daros de Luca's message of Wed Apr 15 12:13:39 +0300 2009:
> Bug #1382: inline functions ought to be static
> http://redmine.ruby-lang.org/issues/show/1382
> 
> Author: Ollivier Robert
> Status: Open, Priority: Normal
> Category: core
> ruby -v: ruby 1.9.2dev (2009-04-14) [i386-darwin9.6.0]
> 
> While compiling Ruby with ongoing versions of clang/llvm, it appeared that
> rb_reserved_word, an inline function in lex.c.blt which is included in parse.y
> is not declared as static as it apparently should (C99). gcc supports it.  Fix
> Ruby for clang.

I think strictly speaking the problem is the declaration
given at the top as non-inline, which causes it to try
an external lookup...so the C99-ish solution would be to
drop the first decl, leave the inline definition and then
define it extern in parse.y.

But making it static is probably simpler.


--
Magic is insufficiently advanced technology.