[ruby-core:119322] [Ruby master Feature#6012] Proc#source_location also return the column

Issue #6012 has been updated by Eregon (Benoit Daloze).


I also really like @ioquatix 's suggestion in https://bugs.ruby-lang.org/issues/6012#note-13 and it is a lot more flexible and more efficient too (since computing e.g. column information if unused is not cheap).
For instance `method.source.code` is great because it completely hides the details how to get the source code and slice it.
TruffleRuby currently keeps the source code in memory and so could provide this automatically without needing to reread the file from disk.
CRuby keeps it but only if `RubyVM.keep_script_lines = true`, so then could use that if available and automatically fallback to read the file from disk (great, because we should avoid users/gems referring to `RubyVM` in their code).

One question is where would we place/how would we name this class?
We could reuse `Thread::Backtrace::Location` as it's quite similar and already has `path`, `lineno`.
But it's not really related to a backtrace here.
Still it seems quite a good fit, and I don't have much idea where to place it otherwise (top-level `Source` seems way too prone for conflicts).

I think in term of the interface we should have:
* start_line
* start_column
* start_offset
* end_line
* end_column
* end_offset
* code: gets the source of the Proc/Method/UnboundMethod

----------------------------------------
Feature #6012: Proc#source_location also return the column
https://bugs.ruby-lang.org/issues/6012#change-109936

* Author: rogerdpack (Roger Pack)
* Status: Assigned
* Assignee: nobu (Nobuyoshi Nakada)
----------------------------------------
As originally suggested in http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/42418

Suggestion/feature request:
have #source_location also return the beginning column where it was defined.
["test.rb", 8, 33]

Thanks!
-roger-




-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- [e-mail]
 To unsubscribe send an email to [e-mail]
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/