From: "mame (Yusuke Endoh) via ruby-core" <ruby-core@...>
Date: 2024-09-30T05:10:58+00:00
Subject: [ruby-core:119345] [Ruby master Bug#20726] Issue with hash without braces when assigned to constant with ractor literals
Issue #20726 has been updated by mame (Yusuke Endoh).
Assignee set to ko1 (Koichi Sasada)
----------------------------------------
Bug #20726: Issue with hash without braces when assigned to constant with ractor literals
https://bugs.ruby-lang.org/issues/20726#change-109956
* Author: luke-gru (Luke Gruber)
* Status: Open
* Assignee: ko1 (Koichi Sasada)
* ruby -v: 3.4.0dev
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
```ruby
# shareable_constant_value: literal
a = 'hi'
A = ['hello' => a]
p A
```
gives:
```
./ruby -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-linux-fake ../ruby/test.rb
-- raw disasm--------
trace: 1
0000 putchilledstring "hi" ( 3)
0002 setlocal_WC_0 3 ( 3)
trace: 1
0004 newarray 1 ( 4)
0006 putspecialobject 3 ( 4)
* 0008 setconstant :A ( 4)
trace: 1
0010 putself ( 5)
0011 opt_getconstant_path [:A] ( 5)
0013 opt_send_without_block <calldata:p, 1> ( 5)
0015 leave ( 5)
---------------------
../ruby/test.rb:4: argument stack underflow (-1)
../ruby/test.rb: compile error (SyntaxError)
```
This is due to a line in `compile.c`, function `compile_shareable_literal_constant`:
```c
if (!RNODE_HASH(node)->nd_brace) { }
```
I'm not sure why this condition is there so I'm not confident in making a fix. Also, my git-fu isn't the best so I can't track down the right commit where it was added.
Expected:
It works just the same as when pragma `shareable_constant_value: literal` is not given. Which is to say, `[{'hello' => 'hi'}]` is is the value of `A`.
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/