[ruby-core:106248] [Ruby master Bug#18356] Please replace use of unsafe MD5 with another digest algorithm

Issue #18356 has been updated by byroot (Jean Boussier).


> Please note that was a filtered list, there are other dependecies, such as pop3/imap, cgi, and other net/ uses.

All theses are "bundled gems", they're basically vendored in ruby but have their own issue trackers e.g. https://github.com/ruby/net-pop

I greped myself for `Digest::MD5` in the actual stdlib, and all I could find is `cgi/session` where the session ID is hashed with MD5 to create a file path, so not a crypto use and changing it would break backward compatibility.

So I'm of the opinion that this issue is not actionable from a Ruby standpoint and should be closed. 

----------------------------------------
Bug #18356: Please replace use of unsafe MD5 with another digest algorithm
https://bugs.ruby-lang.org/issues/18356#change-94868

* Author: pvalena (Pavel Valena)
* Status: Third Party's Issue
* Priority: Normal
* Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
Similarly to https://bugs.ruby-lang.org/issues/18272

## Context
When working on a new version of RHEL (with Ruby 3.0), the requirement is to have a better security (remove unsafe digests or limit the use for non-security purposes). This would be achieved with using OpenSSL 3.0 as well, which will have a raised security level by default, forbidding the use of unsafe digests.

## Issue
MD5 does not conform to the security requirements, and its replacement would be preferred.
Currently, the following files indicate it's use:

```
rubygems/package.rb:    return super unless gem.start.include? 'MD5SUM ='
bundler/compact_index_client/cache.rb:          name += "-#{SharedHelpers.digest(:MD5).hexdigest(name).downcase}"
bundler/compact_index_client/updater.rb:          SharedHelpers.digest(:MD5).hexdigest(File.read(path))
bundler/source/rubygems/remote.rb:            uri_digest = SharedHelpers.digest(:MD5).hexdigest(uri_parts.compact.join("."))
bundler/vendor/thor/lib/thor/runner.rb:      :filename   => Digest::MD5.hexdigest(name + as),
```

## Alternative solution
The use for non-security purposes might be indicated with setting an internal variable (when using OpenSSL implementation), which would allow the use of MD5 (although forbidden via OpenSSL setting). Do you think this would be possible?

## Question
AFAICT in Ruby it is used for non-security purposes only. Could you confirm that?

## Additional information
The tests failed on `digests/md5` removal:
https://gist.github.com/pvalena/ce6af993c6fe7c825cc41be81e1944ad



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>