From: "postmodern (Hal Brodigan)" Date: 2021-11-14T15:46:11+00:00 Subject: [ruby-core:106052] [Ruby master Bug#18334] ENV#to_h returns a new Hash object but Hash#to_h does not, which can cause inconsistencies Issue #18334 has been updated by postmodern (Hal Brodigan). With the current implementation of ENV#to_h, `ENV.to_h.dup` would create two new Hashes instead of one. `hash.to_h.dup` would correctly create only one new Hash. ---------------------------------------- Bug #18334: ENV#to_h returns a new Hash object but Hash#to_h does not, which can cause inconsistencies https://bugs.ruby-lang.org/issues/18334#change-94639 * Author: postmodern (Hal Brodigan) * Status: Open * Priority: Normal * ruby -v: ruby 3.1.0dev (2021-11-13T20:48:57Z master fc456adc6a) [x86_64-linux] * Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN ---------------------------------------- I noticed that in ruby-3.1.0-preview1 ENV#dup was removed in favor of ENV#to_h. However, methods that accept either ENV or a Hash object will not behave the same, since ENV#to_h returns a new Hash object but Hash#to_h returns the same Hash instance. ENV.to_h.object_id # => 14700 ENV.to_h.object_id # => 14760 hash = {"FOO" => "bar"} hash.to_h.object_id # => 14820 hash.to_h.object_id # => 14820 I propose that the ENV#dup method be re-added as `self.to_h.dup`. -- https://bugs.ruby-lang.org/ Unsubscribe: