From: Motohiro KOSAKI Date: 2011-12-20T14:10:07+09:00 Subject: [ruby-dev:45012] [ruby-trunk - Bug #5768] TestRequire#test_race_exceptionで競合するケースがまだある Issue #5768 has been updated by Motohiro KOSAKI. Category set to core Assignee changed from Nobuyoshi Nakada to Motohiro KOSAKI Target version set to 2.0.0 lock_funcやrb_mutex_lockを変更するのは反対なので、いったん預かります ---------------------------------------- Bug #5768: TestRequire#test_race_exceptionで競合するケースがまだある https://bugs.ruby-lang.org/issues/5768 Author: Yui NARUSE Status: Assigned Priority: Normal Assignee: Motohiro KOSAKI Category: core Target version: 2.0.0 ruby -v: ruby 2.0.0dev (2011-12-16 trunk 34058) [x86_64-freebsd9.0] まだrequireで競合するケースが残っています。 現在のテストだと確率的にしか起きませんが、以下の通り変更すると確実に起きるようになります。 diff --git a/test/ruby/test_require.rb b/test/ruby/test_require.rb index 9186a6f..262a5ef 100644 --- a/test/ruby/test_require.rb +++ b/test/ruby/test_require.rb @@ -352,7 +352,7 @@ class TestRequire < Test::Unit::TestCase TestRequire.scratch << :pre Thread.pass until t2 = TestRequire.scratch[1] Thread.pass until t2.stop? -open(__FILE__, "w") {|f| f.puts "TestRequire.scratch << :post"} +open(__FILE__, "w") {|f| f.puts "TestRequire.scratch << :post"; f.puts "t1,t2=TestRequire.scratch[1, 2];if Thread.current == t2; Thread.pass until t1.stopped?; end"} raise "con1" EOS tmp.close @@ -364,6 +364,7 @@ raise "con1" t2_res = nil t1 = Thread.new do + scratch << t1 begin require(path) rescue RuntimeError @@ -389,8 +390,8 @@ raise "con1" assert_nothing_raised(ThreadError, bug5754) {t1.join} assert_nothing_raised(ThreadError, bug5754) {t2.join} - assert_equal(true, (t1_res ^ t2_res), bug5754) - assert_equal([:pre, t2, :post, :t2, :t1], scratch, bug5754) + assert_equal(true, (t1_res ^ t2_res), bug5754 + " t1:#{t1_res} t2:#{t2_res}") + assert_equal([:pre, t1, t2, :post, :t2, :t1], scratch, bug5754) ensure tmp.close(true) if tmp end -- http://redmine.ruby-lang.org