[ruby-dev:23551] Re: Socket.new(Socket::AF_INET, Socket::SOCK_STREAM, 0) dumps core with ruby-1.8.2

山本です。

Tanaka Akira <[e-mail]> wrote:
(2004/05/20 14:59)

>% ./ruby -rsocket -e 'Socket.new(Socket::AF_INET, Socket::SOCK_STREAM, 0)'
>-e:1: [BUG] Segmentation fault
>ruby 1.8.2 (2004-05-17) [i686-linux]


////////////////////////////
// ext/socket/socket.c

Revision : 1.108.2.6
Date : 2004/5/17 7:18:25
Author : 'matz'
State : 'Exp'
Lines : +20 -9
Description :
* ext/socket/socket.c (setup_domain_and_type): honor duck typing.
  [ruby-dev:23522]

* ext/socket/socket.c (sock_s_getnameinfo): ditto.


で入ったバグのようです。HEAD と比べてもこのパッチで間違いないと思うので、
コミットしておきます。

Index: socket.c
===================================================================
RCS file: /ruby/ruby/ext/socket/socket.c,v
retrieving revision 1.108.2.7
diff -u -w -b -p -r1.108.2.7 socket.c
--- socket.c	20 May 2004 06:04:39 -0000	1.108.2.7
+++ socket.c	20 May 2004 06:46:46 -0000
@@ -1745,7 +1745,7 @@ setup_domain_and_type(domain, dv, type, 
     char *ptr;
 
     tmp = rb_check_string_type(domain);
-    if (!NIL_P(domain)) {
+    if (!NIL_P(tmp)) {
 	domain = tmp;
 	rb_check_safe_obj(domain);
 	ptr = RSTRING(domain)->ptr;