[ruby-core:94426] [Ruby master Misc#16109] Normalize legacy tag names
From:
takashikkbn@...
Date:
2019-08-19 07:08:43 UTC
List:
ruby-core #94426
Issue #16109 has been updated by k0kubun (Takashi Kokubun).
Done. Here's the full operation log:
```
$ git push origin :v1_3_1_
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] v1_3_1_
To git.ruby-lang.org:ruby.git
- [deleted] v1_3_1_
$ git push origin :RUBY_1_3
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] RUBY_1_3
To git.ruby-lang.org:ruby.git
- [deleted] RUBY_1_3
$ git push origin :ruby_1_4_3
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] ruby_1_4_3
To git.ruby-lang.org:ruby.git
- [deleted] ruby_1_4_3
$ git push origin :ruby1_4_3
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] ruby1_4_3
To git.ruby-lang.org:ruby.git
- [deleted] ruby1_4_3
$ git push origin ruby_1_4_3_pre1:refs/tags/v1_4_3_preview1
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] 458186581c672de13c4573b0ab7467d9909d376b -> v1_4_3_preview1
To git.ruby-lang.org:ruby.git
* [new tag] ruby_1_4_3_pre1 -> v1_4_3_preview1
$ git push origin :ruby_1_4_3_pre1
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] ruby_1_4_3_pre1
To git.ruby-lang.org:ruby.git
- [deleted] ruby_1_4_3_pre1
$ git push origin ruby_1_8_freeze_candidate:refs/tags/v1_8_5_freeze_candidate
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] 461c63804e79acf7000c6c572671f24ee5f6006b -> v1_8_5_freeze_candidate
To git.ruby-lang.org:ruby.git
* [new tag] ruby_1_8_freeze_candidate -> v1_8_5_freeze_candidate
$ git push origin :ruby_1_8_freeze_candidate
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] ruby_1_8_freeze_candidate
To git.ruby-lang.org:ruby.git
- [deleted] ruby_1_8_freeze_candidate
$ git push origin yarv_migration_base:refs/tags/v1_9_0_yarv_migration_base
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] 20c8803697df39a086175a5eb2f8e8ee00bf1e2f -> v1_9_0_yarv_migration_base
To git.ruby-lang.org:ruby.git
* [new tag] yarv_migration_base -> v1_9_0_yarv_migration_base
$ git push origin :yarv_migration_base
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] yarv_migration_base
To git.ruby-lang.org:ruby.git
- [deleted] yarv_migration_base
$ git push origin r1_1b9:refs/tags/v1_1b9
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] c3573837accf17b540e97ff389a83e5288da9d93 -> v1_1b9
To git.ruby-lang.org:ruby.git
* [new tag] r1_1b9 -> v1_1b9
$ git push origin :r1_1b9
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] r1_1b9
To git.ruby-lang.org:ruby.git
- [deleted] r1_1b9
$ git push origin r1_1b9_24:refs/tags/v1_1b9_24
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] 6099ec515620d3d905fa6769f66b61c561d3dda7 -> v1_1b9_24
To git.ruby-lang.org:ruby.git
* [new tag] r1_1b9_24 -> v1_1b9_24
$ git push origin :r1_1b9_24
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] r1_1b9_24
To git.ruby-lang.org:ruby.git
- [deleted] r1_1b9_24
# the new name in this push was a mistake... fixed from the next step
$ git push origin r1_1b9_25:refs/tags/v1_1b9_r25
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] f5dcdd62e3a5b769ce59ad92a866ca339e14104b -> v1_1b9_r25
To git.ruby-lang.org:ruby.git
* [new tag] r1_1b9_25 -> v1_1b9_r25
$ git push origin :r1_1b9_25
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] r1_1b9_25
To git.ruby-lang.org:ruby.git
- [deleted] r1_1b9_25
$ git fetch origin --tags
remote: Counting objects: 8, done.
remote: Compressing objects: 100% (8/8), done.
remote: Total 8 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (8/8), done.
From git.ruby-lang.org:ruby
c5db4c28f9..4515bcc922 master -> origin/master
0e38368894..bad6483364 ruby_2_5 -> origin/ruby_2_5
51edcbad5b..4515bcc922 trunk -> origin/trunk
* [new tag] v1_1b9 -> v1_1b9
* [new tag] v1_1b9_24 -> v1_1b9_24
* [new tag] v1_1b9_r25 -> v1_1b9_r25
* [new tag] v1_4_3_preview1 -> v1_4_3_preview1
* [new tag] v1_8_5_freeze_candidate -> v1_8_5_freeze_candidate
* [new tag] v1_9_0_yarv_migration_base -> v1_9_0_yarv_migration_base
$ git push origin v1_1b9_r25:v1_1b9_25
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] f5dcdd62e3a5b769ce59ad92a866ca339e14104b -> v1_1b9_25
To git.ruby-lang.org:ruby.git
* [new tag] v1_1b9_r25 -> v1_1b9_25
# fixing the wrong name done
$ git push origin :v1_1b9_r25
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] v1_1b9_r25
To git.ruby-lang.org:ruby.git
- [deleted] v1_1b9_r25
$ git push origin :v_1_8_5_52
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] v_1_8_5_52
To git.ruby-lang.org:ruby.git
- [deleted] v_1_8_5_52
$ git push origin :v_1_8_6_30
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] v_1_8_6_30
To git.ruby-lang.org:ruby.git
- [deleted] v_1_8_6_30
$ git push origin :v_1_8_6_31
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] v_1_8_6_31
To git.ruby-lang.org:ruby.git
- [deleted] v_1_8_6_31
$ git push origin :v_1_8_6_36
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] v_1_8_6_36
To git.ruby-lang.org:ruby.git
- [deleted] v_1_8_6_36
$ git push origin :v_1_9_1_preview1
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] v_1_9_1_preview1
To git.ruby-lang.org:ruby.git
- [deleted] v_1_9_1_preview1
$ git push origin RUBY-SHA1_v1_2:refs/tags/sha1_1_2
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] 82c28e5e50bf48d091626b70efa4321334acb6b0 -> sha1_1_2
To git.ruby-lang.org:ruby.git
* [new tag] RUBY-SHA1_v1_2 -> sha1_1_2
$ git push origin :RUBY-SHA1_v1_2
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] RUBY-SHA1_v1_2
To git.ruby-lang.org:ruby.git
- [deleted] RUBY-SHA1_v1_2
$ git push origin V1-1-1:net_1_1_1
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] de9e8c7fd35edf385dec5b0453ba2df16bcbf227 -> net_1_1_1
To git.ruby-lang.org:ruby.git
* [new tag] V1-1-1 -> net_1_1_1
$ git push origin :V1-1-1
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] V1-1-1
To git.ruby-lang.org:ruby.git
- [deleted] V1-1-1
$ git push origin V1-1-3:net_1_1_3
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] cd57d9634d4779e28257677cfda95027dda6fb5a -> net_1_1_3
To git.ruby-lang.org:ruby.git
* [new tag] V1-1-3 -> net_1_1_3
$ git push origin :V1-1-3
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] V1-1-3
To git.ruby-lang.org:ruby.git
- [deleted] V1-1-3
$ git push origin v0_7_1:irb_0_7_1
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] f6f0faf798be15e78463e8281166b720b625ec3d -> irb_0_7_1
To git.ruby-lang.org:ruby.git
* [new tag] v0_7_1 -> irb_0_7_1
$ git push origin :v0_7_1
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] v0_7_1
To git.ruby-lang.org:ruby.git
- [deleted] v0_7_1
$ git push origin v0_7_3:irb_0_7_3
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] ea16465a20601faec9acf39a255ec84aebe49485 -> irb_0_7_3
To git.ruby-lang.org:ruby.git
* [new tag] v0_7_3 -> irb_0_7_3
$ git push origin :v0_7_3
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] v0_7_3
To git.ruby-lang.org:ruby.git
- [deleted] v0_7_3
$ git push origin testunit_0-1-7:testunit_0_1_7
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] 4fcfeae6143a480df6b766290ee50f23b3e1a68b -> testunit_0_1_7
To git.ruby-lang.org:ruby.git
* [new tag] testunit_0-1-7 -> testunit_0_1_7
$ git push origin :testunit_0-1-7
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] testunit_0-1-7
To git.ruby-lang.org:ruby.git
- [deleted] testunit_0-1-7
$ git push origin testunit_0-1-8:testunit_0_1_8
Total 0 (delta 0), reused 0 (delta 0)
remote: To git@github.com:ruby/ruby.git
remote: * [new tag] 2eb2c5c20d10048510f6e6d5233fb49157b31831 -> testunit_0_1_8
To git.ruby-lang.org:ruby.git
* [new tag] testunit_0-1-8 -> testunit_0_1_8
$ git push origin :testunit_0-1-8
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] testunit_0-1-8
To git.ruby-lang.org:ruby.git
- [deleted] testunit_0-1-8
```
----------------------------------------
Misc #16109: Normalize legacy tag names
https://bugs.ruby-lang.org/issues/16109#change-80851
* Author: k0kubun (Takashi Kokubun)
* Status: Open
* Priority: Normal
* Assignee:
----------------------------------------
There are tags with inconsistent names. To browse the history more easily, I propose the following normalization.
**Before and after the renames, I'm going to record `git ls-remote` in this ticket. By doing so, we'd be able to revert this ticket's change as needed.**
# Ruby's version tags
## v1_3_1_ -> (deleted)
This is the same as v1_3_1_990126 except svn-related meta commits.
## RUBY_1_3 -> (deleted)
This is the same as v1_3_1_990126 except svn-related meta commits.
We also have `ruby_1_3` branch for 1.3 stable branch, and the branch should own that role.
## ruby_1_4_3, ruby1_4_3 -> (deleted)
Both tags are the same as `v1_4_3` except svn-related meta commits.
## ruby_1_4_3_pre1 -> v1_4_3_preview1
Just normalize the name.
## ruby_1_8_freeze_candidate -> v1_8_5_freeze_candidate
Minor normalization, and clarify the exact version. Thoughts?
## yarv_migration_base -> v1_9_0_yarv_migration_base
Make it slightly more consistent with other tags, and clarify the exact version. Thoughts?
## r1_1b9 -> v1_1b9
## r1_1b9_24 -> v1_1b9_24
## r1_1b9_25 -> v1_1b9_25
Just make them similar to other tags like v1_1b8, v1_1b9_07.
## v_1_8_5_52 -> (deleted)
## v_1_8_6_30 -> (deleted)
## v_1_8_6_31 -> (deleted)
## v_1_8_6_36 -> (deleted)
All of them have their `s/v_/v/` version, and their differences are only a "move to proper name" commit and thus it looks intended to be renamed in that direction.
## v_1_9_1_preview1 -> (deleted)
Excluding meta commits, v1_9_1_preview1 is just 1-commit (r19982) ahead of v_1_9_1_preview1. Just leaving v1_9_1_preview1 seems fine.
# Library's version tags
Currently they're named inconsistently:
```
REXML_2_7_0
RUBY-SHA1_v1_2
SHELL_v0_6
V1-1-1
V1-1-3
forwardable_v1_1
gtk_012
irb_0_9
v0_7_1
v0_7_3
oniguruma_2_2_4
oniguruma_2_2_5
oniguruma_2_2_6
oniguruma_2_2_7
oniguruma_2_2_8
oniguruma_3_4_0
oniguruma_3_5_4
oniguruma_3_6_0
oniguruma_3_7_0
oniguruma_3_7_0_1
testunit_0-1-7
testunit_0-1-8
```
Especially tags without a library name are very confusing.
## Changes
How about having the following changes to this?
They are changed to `#{name}_#{x}_#{y}_#{z}` to minimize changes and for consistency with existing tags for now.
```
RUBY-SHA1_v1_2 -> sha1_1_2
V1-1-1 -> net_1_1_1
V1-1-3 -> net_1_1_3
v0_7_1 -> irb_0_7_1
v0_7_3 -> irb_0_7_3
testunit_0-1-7 -> testunit_0_1_7
testunit_0-1-8 -> testunit_0_1_8
```
## Unchanged
Following things seem to be fine, compared to the above ones.
`#{name}_v#{x}_#{y}_#{z}` is allowed in addition to `#{name}_#{x}_#{y}_#{z}`.
```
gtk_012
irb_0_9
REXML_2_7_0
SHELL_v0_6
forwardable_v1_1
oniguruma_2_2_4
oniguruma_2_2_5
oniguruma_2_2_6
oniguruma_2_2_7
oniguruma_2_2_8
oniguruma_3_4_0
oniguruma_3_5_4
oniguruma_3_6_0
oniguruma_3_7_0
oniguruma_3_7_0_1
```
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>