From: shevegen@... Date: 2019-08-04T13:24:49+00:00 Subject: [ruby-core:94136] [Ruby master Bug#16043] `$LOAD_PATH.resolve_feature_path` should not raise Issue #16043 has been updated by shevegen (Robert A. Heiler). > read in the docs and discussion that this method only searches the feature in the LOAD_PATH, > but does not attempt to load it. Raising a load error makes it look that this method tries > to load the feature, but I don't think it does that. I had a look at the tracker: https://bugs.ruby-lang.org/issues/15230 And I agree with you in the sense that mame did not mandate that the method should raise, so it probably should not raise (or it should be mentioned in the documentation, IMO). I have no opinion on what it should return but I think either way it would be best to specify it, to less confusion by other ruby users. It may be best to ask mame directly whether he agrees with your comment + patch. :) ---------------------------------------- Bug #16043: `$LOAD_PATH.resolve_feature_path` should not raise https://bugs.ruby-lang.org/issues/16043#change-80386 * Author: deivid (David Rodr�guez) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.7.0dev * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- When I first tried this method, I was expecting it to return `nil` when the given feature is not found. This is because I read in the docs and discussion that this method only searches the feature in the LOAD_PATH, but does not attempt to load it. Raising a load error makes it look that this method tries to load the feature, but I don't think it does that. Also returning `nil` seems friendlier to me because the "feature not found" case is more like an expected outcome of the method than a real error condition, so in most usages this error will actually be rescued for control flow. I attach a patch with the change, and link to the GH PR: https://github.com/ruby/ruby/pull/2317. ---Files-------------------------------- 0001-LOAD_PATH.resolve_feature_path-should-not-raise.patch (1.13 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: