From: takashikkbn@... Date: 2019-08-09T02:35:30+00:00 Subject: [ruby-core:94212] [Ruby master Misc#16089] Explain that github prs do not get merged Issue #16089 has been updated by k0kubun (Takashi Kokubun). Good news is, yesterday I discussed this issue with @mame who was the person opposed to having a merge commit, and we got an idea to solve his problems. Once it's implemented (work in progress; @mame implemented one, and I'm going to implement the other piece), we'd be able to create a merge commit. By just using a merge commit, your pull requests will not be "Closed" but "Merged" on GitHub too. So I hope you'll like our workflow a little bit more after that. ---------------------------------------- Misc #16089: Explain that github prs do not get merged https://bugs.ruby-lang.org/issues/16089#change-80510 * Author: dmr (daniel radetsky) * Status: Closed * Priority: Normal * Assignee: ---------------------------------------- The fact that fixes which are accepted still get closed, rather than being merged, is confusing. The (easiest) solution is to modify https://bugs.ruby-lang.org/projects/ruby/wiki/HowToContribute Change submit section to something like "Pull request to https://github.com/ruby/ruby is acceptable for tiny fixes. But pull requests which need discussions will be ignored unless you create a redmine ticket. Note that even accepted pull requests are closed, not merged, because github is not the canonical ruby repo." I'd do this myself, but either I'm not allowed to edit this page, or I can't figure out how. This was discussed a bit in https://github.com/ruby/ruby/pull/2323 -- https://bugs.ruby-lang.org/ Unsubscribe: