From: merch-redmine@... Date: 2019-08-08T16:39:59+00:00 Subject: [ruby-core:94204] [Ruby master Misc#16089] Explain that github prs do not get merged Issue #16089 has been updated by jeremyevans0 (Jeremy Evans). Status changed from Open to Closed I've updated the wiki to reflect this. If you think additional changes are needed, please reply. ---------------------------------------- Misc #16089: Explain that github prs do not get merged https://bugs.ruby-lang.org/issues/16089#change-80497 * Author: dmr (daniel radetsky) * Status: Closed * Priority: Normal * Assignee: ---------------------------------------- The fact that fixes which are accepted still get closed, rather than being merged, is confusing. The (easiest) solution is to modify https://bugs.ruby-lang.org/projects/ruby/wiki/HowToContribute Change submit section to something like "Pull request to https://github.com/ruby/ruby is acceptable for tiny fixes. But pull requests which need discussions will be ignored unless you create a redmine ticket. Note that even accepted pull requests are closed, not merged, because github is not the canonical ruby repo." I'd do this myself, but either I'm not allowed to edit this page, or I can't figure out how. This was discussed a bit in https://github.com/ruby/ruby/pull/2323 -- https://bugs.ruby-lang.org/ Unsubscribe: