From: dradetsky@... Date: 2019-08-08T16:20:52+00:00 Subject: [ruby-core:94203] [Ruby master Misc#16089] Explain that github prs do not get merged Issue #16089 has been updated by dmr (daniel radetsky). I actually realize that this is wrong & that technically it's "accepted pull requests are _often_ closed, not merged, because..." ---------------------------------------- Misc #16089: Explain that github prs do not get merged https://bugs.ruby-lang.org/issues/16089#change-80495 * Author: dmr (daniel radetsky) * Status: Open * Priority: Normal * Assignee: ---------------------------------------- The fact that fixes which are accepted still get closed, rather than being merged, is confusing. The (easiest) solution is to modify https://bugs.ruby-lang.org/projects/ruby/wiki/HowToContribute Change submit section to something like "Pull request to https://github.com/ruby/ruby is acceptable for tiny fixes. But pull requests which need discussions will be ignored unless you create a redmine ticket. Note that even accepted pull requests are closed, not merged, because github is not the canonical ruby repo." I'd do this myself, but either I'm not allowed to edit this page, or I can't figure out how. This was discussed a bit in https://github.com/ruby/ruby/pull/2323 -- https://bugs.ruby-lang.org/ Unsubscribe: