[ruby-core:88859] [Ruby trunk Feature#15076] Struct to raise error when keyword arguments used but not enabled

From: takashikkbn@...
Date: 2018-09-05 11:58:41 UTC
List: ruby-core #88859
Issue #15076 has been updated by k0kubun (Takashi Kokubun).


> Will it be clearer if a error is raised instead rather than assigning data incorrectly ?

With the current keyword arguments implementation (see also: [Feature #14183]), we can't distinguish the mistaken situation with one that we really wanted to initialize only the first argument with set Symbol-key Hash. So that would be breaking change which we basically shouldn't introduce.

----------------------------------------
Feature #15076: Struct to raise error when keyword arguments used but not enabled
https://bugs.ruby-lang.org/issues/15076#change-73898

* Author: macdevign (Macdevign mac)
* Status: Rejected
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
When Struct is used to instantiate object with keyword arguments disabled and yet if instantiated using keyword arguments, the instance fields will be set incorrectly. 

Will it be clearer if a error is raised instead rather than assigning data incorrectly ? This is helpful and save time in nailing such issue in a large code base when there is mixture of Struct define with and without keyword arguments.

For example,

~~~ ruby
Info = Struct.new(:name, :country)  # without keyword argument enabled
c = Info.new(name: "myname", country: "Japan") # Instantiate with keywords
~~~

The c.name contains hash, and c.country is nil




-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next