[ruby-core:88853] [Ruby trunk Feature#15066][Feedback] Documentation and providing better API for accessing Complex numbers functions in C extensions

From: nobu@...
Date: 2018-09-05 07:37:04 UTC
List: ruby-core #88853
Issue #15066 has been updated by nobu (Nobuyoshi Nakada).

Status changed from Open to Feedback

v0dro (Sameer Deshmukh) wrote:
> > Isn't it enough to just use rb_funcall() to call Ruby methods on Complex numbers?
> 
> Calling Ruby methods in C extensions defeats the purpose of writing a C extension since a non-trivial number of Ruby method calls take up significant time.

What APIs do you need?
A concrete list, please.

> > RCOMPLEX_SET_REAL and RCOMPLEX_SET_IMAG are internal macros, and so I think they should not be used outside.
> 
> Both these macros are included in the ruby.h so I thought they're public. Maybe you want to remove them from there?

Removed them yesterday.



----------------------------------------
Feature #15066: Documentation and providing better API for accessing Complex numbers functions in C extensions
https://bugs.ruby-lang.org/issues/15066#change-73892

* Author: v0dro (Sameer Deshmukh)
* Status: Feedback
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
Currently there is absolutely no documentation for working with Complex numbers at the level of the C API.

Apart from two macros defined [[here](https://github.com/ruby/ruby/blob/trunk/include/ruby/ruby.h#L1079)] for setting the real and imag
values of Complex numbers there is no 'official' way of working with Complex numbers at the level of the C API.

I propose two things:
* Fully document existing Complex number routines.
* Provide a robust and efficient API for dealing with complex numbers from C extensions.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next