From: Greg.mpls@... Date: 2018-09-27T23:17:07+00:00 Subject: [ruby-core:89200] [Ruby trunk Bug#15162] Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW Issue #15162 has been updated by MSP-Greg (Greg L). @hsbt I just did twenty runs of core/encoding, then twenty runs of the full spec suite. No silent SEGV's. Hence, the patch works. Thank you. Whoever does the commmit, please remember to remove the two `.name` method calls on line 30 of `spec/ruby/core/encoding/converter/search_convpath_spec.rb` Benoit - I can't seem to ping you using either @eregon or @Eregon ---------------------------------------- Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW https://bugs.ruby-lang.org/issues/15162#change-74225 * Author: Eregon (Benoit Daloze) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.6.0dev (2018-09-26) [x64-mingw32] * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- It seems to work fine with String arguments, but not Encoding objects where it SEGV, at least in some runs. See https://github.com/ruby/ruby/commit/f00bf242724d40d59a242c6bf9e567d18c9e1872#commitcomment-30650955 cc @MSP-Greg ---Files-------------------------------- 0001-transcode.c-add-GC-guard-on-raise.patch (1.04 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: