From: artur.beljajev@...
Date: 2018-03-18T22:42:12+00:00
Subject: [ruby-core:86192] [Ruby trunk Bug#14615] Checking HTTP::Net response

Issue #14615 has been reported by artur86 (Artur Beljajev).

----------------------------------------
Bug #14615: Checking HTTP::Net response
https://bugs.ruby-lang.org/issues/14615

* Author: artur86 (Artur Beljajev)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Currently you need to either use `kind_of?` or `HTTPResponse#code` to find out the type of a response.

~~~ ruby
response = Net::HTTP.start(uri.hostname, 
                           uri.port,
                           use_ssl: (uri.scheme == 'https'),
                           cert: OpenSSL::X509::Certificate.new(client_cert),
                           key: OpenSSL::PKey::RSA.new(client_key)) do |http|
  http.request(request)
end

if response.code || response.kind_of?(Net::HTTPSuccess)
  ...
end
~~~

How about using data from either `Rack::Utils::SYMBOL_TO_STATUS_CODE` or `Net::HTTPResponse::CODE_TO_OBJ` to simply it to:
~~~
if response.ok?
...
end

in the same way as Rails does https://github.com/rails/rails/blob/2090615d39c071c9eb25e715275eb79f3f9b6266/actionpack/lib/action_dispatch/testing/assertions/response.rb#L22.
~~~



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>