[ruby-core:82081] [Ruby trunk Bug#13569] Windows - TestRubyOptions#test_search - append to paths instead of replacing

Issue #13569 has been updated by MSP-Greg (Greg L).


Decided to re-run this test, as it's been a while.  I've been applying the patch before my normal test runs, so I haven't checked for its (continued) failure for a while.  Given that my test results have been consistent across all test sets, I doubt I've got something wrong with my env setup during testing.

Note that if I run this test with runner.rb in a windows env, the test passes.  But as noted below, it fails when run with make (I set a make env by adding `msys64\mingw64\bin` and `msys64\usr\bin` to my path.)

Below is a command window grab from a make test:

```
E:\GitHub\ruby-loco\src\build-x86_64>make.exe "TESTOPTS= --show-skip ../ruby/test/ruby/test_rubyoptions.rb" test-all
Run options: "--ruby=./miniruby.exe -I../ruby/lib -I. -I.ext/common  ../ruby/tool/runruby.rb --extout=.ext  -- --disable-gems" --excludes-dir=../ruby/
test/excludes --name=!/memory_leak/ --show-skip

# Running tests:


  1) Skipped:
TestRubyOptions#test_set_program_name [E:/GitHub/ruby/test/ruby/test_rubyoptions.rb:514]:
platform dependent feature

  2) Skipped:
TestRubyOptions#test_setproctitle [E:/GitHub/ruby/test/ruby/test_rubyoptions.rb:533]:
platform dependent feature

  3) Failure:
TestRubyOptions#test_search [E:/GitHub/ruby/test/ruby/test_rubyoptions.rb:303]:

1. [1/2] Assertion for "stdout"
   | <["1"]> expected but was
   | <[]>.

Finished tests in 18.127200s, 3.0341 tests/s, 47.0564 assertions/s.
55 tests, 853 assertions, 1 failures, 0 errors, 2 skips

ruby -v: ruby 2.5.0dev (2017-07-17 trunk 59347) [x64-mingw32]
make: *** [uncommon.mk:684: yes-test-all] Error 1
```

If you cannot repo this, please feel free to respond.

----------------------------------------
Bug #13569: Windows - TestRubyOptions#test_search - append to paths instead of replacing
https://bugs.ruby-lang.org/issues/13569#change-65812

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.5.0dev (2017-05-11 trunk 58657) [x64-mingw32]
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
[TestRubyOptions#test_search](https://github.com/ruby/ruby/blob/trunk/test/ruby/test_rubyoptions.rb#L299) replaces `ENV['PATH']`, which causes a failure under Windows.  PR appends, rather than replacing.

See [GitHub PR 1616](https://github.com/ruby/ruby/pull/1616).







-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>