[ruby-core:81954] [Ruby trunk Bug#13723] Change to use RubyVM for syntax check in test suite breaks suite for non-MRI

From: nobu@...
Date: 2017-07-07 12:08:33 UTC
List: ruby-core #81954
Issue #13723 has been updated by nobu (Nobuyoshi Nakada).


In some cases, `RubyVM::InstructionSequence.compile` and `eval` fail in different manor.

```ruby
RubyVM::InstructionSequence.compile("break") #=> Invalid break
eval("break") #=> Can't escape from eval with break
```

----------------------------------------
Bug #13723: Change to use RubyVM for syntax check in test suite breaks suite for non-MRI
https://bugs.ruby-lang.org/issues/13723#change-65676

* Author: headius (Charles Nutter)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
In revision 57158 (6b5f9277 on github) nobu modified the syntax checks in test/lib/test/unit/assertions.rb to use MRI-specific features.

https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/57158

Specifically, instead of using eval to check syntax, it now uses RubyVM::InstructionSequence, which only exists on MRI.

Because of the way the MRI tests are structured, we need to use test/lib contents on JRuby to run the tests. This change means a number of tests that passed before now fail, because we don't support RubyVM::InstructionSequence.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next