From: usa@... Date: 2017-07-18T12:37:33+00:00 Subject: [ruby-core:82096] [Ruby trunk Misc#13702][Assigned] TZ checking in rb_w32_fstati64() Issue #13702 has been updated by usa (Usaku NAKAMURA). Status changed from Open to Assigned Assignee set to usa (Usaku NAKAMURA) ---------------------------------------- Misc #13702: TZ checking in rb_w32_fstati64() https://bugs.ruby-lang.org/issues/13702#change-65830 * Author: kubo (Takehiro Kubo) * Status: Assigned * Priority: Normal * Assignee: usa (Usaku NAKAMURA) ---------------------------------------- The environment variable TZ is checked in rb_w32_fstati64(). https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/59061/entry/win32/win32.c#L5417 This was added in r48394 to make File#stat faster. I guess that it was added not to call GetFileInformationByHandle() when TZ isn't set. But the effect has turned off since r50870 because it calls GetFileInformationByHandle() even when TZ isn't set. As a result, the TZ checking in rb_w32_fstati64() is meaningless now. IMO, the following lines could be removed without side effects. * if-clause in rb_w32_fstati64() (line 5417-5421 in win32/win32.c) * stati64_set_inode_handle() (line 5379-5390 in win32/win32.c) -- https://bugs.ruby-lang.org/ Unsubscribe: