From: Eric Wong <normalperson@...>
Date: 2017-06-13T22:29:05+00:00
Subject: [ruby-core:81668] Re: [ruby-cvs:66251] ko1:r59074 (trunk): fix to free unallocated memory.

ko1@ruby-lang.org wrote:
>   New Revision: 59074
> 
>   https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=59074
> 
>   Log:
>     fix to free unallocated memory.
>     
>     * compile.c (iseq_set_sequence): initialize with NULL for line_info_table
>       and generated_iseq and check NULL at BADINSN_ERROR.

I don't think the change to BADINSN_ERROR is necessary.

xfree (and free) already allow NULL arg; and optimizing away a
a function call with extra branch isn't worth it for error handling.

Thanks.

> 
>   Modified files:
>     trunk/compile.c

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>