From: Greg.mpls@...
Date: 2017-06-05T16:32:05+00:00
Subject: [ruby-core:81582] [Ruby trunk Feature#13570] Using mkmf for	ruby/spec C API specs

Issue #13570 has been updated by MSP-Greg (Greg L).


nobu (Nobuyoshi Nakada) wrote:
> test-spec runs fine on AppVeyor, test/ruby/test_rubyoptions.rb has a failure when locale and filesystem encodings differ.
> Another problem is that it consumes 15 min, vs 8 min without tests.

Thank you for working on that (in addition to everything else you do).

MinGW has the same failure, as discussed previously.  In my test results log, failures jumped from 5 to 6.  That's when I decided to remove the chcp and RUBYOPT changes from my build code.  

Re my MinGW test-all, I guess my goals were/are:

1. It completes
2. Consistent failures/errors
3. Minimize skips
4. Consistent tests/assertions
5. WHY DOES THIS TAKE SO LONG / parallel test

I haven't gotten to 5...

----------------------------------------
Feature #13570: Using mkmf for ruby/spec C API specs
https://bugs.ruby-lang.org/issues/13570#change-65286

* Author: Eregon (Benoit Daloze)
* Status: Assigned
* Priority: Normal
* Assignee: cruby-windows
* Target version: 
----------------------------------------
Hello all,

I am thinking to use mkmf to compile the C API specs.

https://github.com/ruby/ruby/blob/trunk/spec/rubyspec/optional/capi/spec_helper.rb
is getting pretty complex and hard to maintain.

I have a few questions:
* Does mkmf works well on Windows?
* What is a good way to compile a single .c file with mkmf to a given library file in another directory?

I tried this but I am not sure it's correct:

~~~ ruby
def compile_extension(name)
  objdir = object_path
  ext = "#{name}_spec"
  lib = "#{objdir}/#{ext}.#{RbConfig::CONFIG['DLEXT']}"

  require 'mkmf' # TODO: probably best to use a subprocess to avoid polluting the namespace
  Dir.chdir(objdir) do
    $srcs = ["#{extension_path}/#{ext}.c"]
    $objs = ["#{extension_path}/#{ext}.o"] # should probably be in objdir but that does not seem to work
    create_makefile(ext)
    system "make"
  end

  lib
end
~~~

Alternatively, we can copy the needed files to a temporary directory, build there and copy the shared library back.
It's a bit more work but not a big deal either.

---Files--------------------------------
spec_helper.rb (2.22 KB)
spec_helper.rb (2.24 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>