From: eregontp@... Date: 2017-06-01T19:08:28+00:00 Subject: [ruby-core:81513] [Ruby trunk Feature#13570] Using mkmf for ruby/spec C API specs Issue #13570 has been updated by Eregon (Benoit Daloze). MSP-Greg (Greg L) wrote: > I checked on MinGW, and there is not an issue with `File.rename` with `src` and `dest` being on different drives. Where I got that from, I don't know... It's the semantics of the rename(2) syscall on Linux, which throws EXDEV if oldpath and newpath are not on the same mounted filesystem. And indeed, on Linux: > File.write "foo","abc" > File.rename "foo", "/tmp/bla" Errno::EXDEV: Invalid cross-device link @ rb_file_s_rename - (foo, /tmp/bla) So we would need some special handling to move files across filesystems on non-Windows, or use FileUtils.mv > > MSpec's #cp should use "rb"/"wb" modes obviously. > Would it work with that? > > Yes and haven't tried. Seems odd to copy a file when a rename will do... Indeed, moving sounds nicer in principle. The reason I like the copy is to help debugging, the .so is still in tmpdir used for compilation along other files. But it's a small thing, looking for the moved file is fine as well. ---------------------------------------- Feature #13570: Using mkmf for ruby/spec C API specs https://bugs.ruby-lang.org/issues/13570#change-65220 * Author: Eregon (Benoit Daloze) * Status: Assigned * Priority: Normal * Assignee: cruby-windows * Target version: ---------------------------------------- Hello all, I am thinking to use mkmf to compile the C API specs. https://github.com/ruby/ruby/blob/trunk/spec/rubyspec/optional/capi/spec_helper.rb is getting pretty complex and hard to maintain. I have a few questions: * Does mkmf works well on Windows? * What is a good way to compile a single .c file with mkmf to a given library file in another directory? I tried this but I am not sure it's correct: ~~~ ruby def compile_extension(name) objdir = object_path ext = "#{name}_spec" lib = "#{objdir}/#{ext}.#{RbConfig::CONFIG['DLEXT']}" require 'mkmf' # TODO: probably best to use a subprocess to avoid polluting the namespace Dir.chdir(objdir) do $srcs = ["#{extension_path}/#{ext}.c"] $objs = ["#{extension_path}/#{ext}.o"] # should probably be in objdir but that does not seem to work create_makefile(ext) system "make" end lib end ~~~ Alternatively, we can copy the needed files to a temporary directory, build there and copy the shared library back. It's a bit more work but not a big deal either. ---Files-------------------------------- spec_helper.rb (2.22 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: