[ruby-core:69724] [Ruby trunk - Bug #11247] [Assigned] Should position of `using` affect the behavior?

Issue #11247 has been updated by Shugo Maeda.

Status changed from Open to Assigned
Assignee changed from Shugo Maeda to Koichi Sasada

Koichi Sasada wrote:
> Recent fix changed behavior of this script.
> 
> * trunk in May: C and R1, C
> * current trunk: R1, C and R1, C
> 
> This change is caused by sharing CREF between methods in same CREF scope. It reduce memory consumption (before this fix, we need one CREF per one method).
> 
> Is it acceptable change or unacceptable?

It's unacceptable.  CREF should be copied at least when refinements are activated in the context.


----------------------------------------
Bug #11247: Should position of `using` affect the behavior?
https://bugs.ruby-lang.org/issues/11247#change-53103

* Author: Koichi Sasada
* Status: Assigned
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: ruby 2.3.0dev (2015-06-11 trunk 50798) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
The following script makes two refinements refine class C.

```ruby
class C
  def foo
    p C
  end
end

module R1
  refine C do
    def foo
      p R1
      super
    end
  end
end

module R2
  refine C do
    def bar
      C.new.foo
    end

    using R1

    def baz
      C.new.foo
    end
  end
end

using R2

C.new.bar
C.new.baz
```

R2 refines C with methods `bar` and `baz`. The difference is the place of `using`. `bar` is located before `using` and `baz` is after.

Recent fix changed behavior of this script.

* trunk in May: C and R1, C
* current trunk: R1, C and R1, C

This change is caused by sharing CREF between methods in same CREF scope. It reduce memory consumption (before this fix, we need one CREF per one method).

Is it acceptable change or unacceptable?




-- 
https://bugs.ruby-lang.org/