From: mail@...
Date: 2015-06-11T06:33:37+00:00
Subject: [ruby-core:69521] [Ruby trunk - Feature #10974] [PATCH] Remove methods with `!`(sin!, cos!…) from CMath

Issue #10974 has been updated by gogo tanaka.

File deprecate_CMath_methods.patch added

Eric Wong wrote:
>  I don't use CMath, but I suggest a deprecation period since it appears
>  this is a public API.  We should never break public API without adequate
>  warning.
>  
>  Maybe:
>  1. deprecate at 2.3.0
>  2. remove when 2.3 branch is EOL for backports/releases

Thanks for comment! I suppose these methods(Math.cos!, sin!..) got public by accident, but your point dose really make sense.
Here is a patch to deprecate these methods.

I'll commit it in a while.

----------------------------------------
Feature #10974: [PATCH] Remove methods with `!`(sin!, cos!���) from CMath
https://bugs.ruby-lang.org/issues/10974#change-52831

* Author: gogo tanaka
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Hi, now I���d like to remove methods with `!`( `sin!`, `cos!`���) from `CMath`, for the following reasons.

* wanna keep CMath minimal. `CMath#sin` should be superset of `CMath#sin!` or `Math#sin` is enough.

* [rdoc for CMath seems broken](http://ruby-doc.org/stdlib-2.2.1/libdoc/cmath/rdoc/CMath.html), `CMath#sin!` isn't alias for `CMath#sin`

thanks, gogo.

---Files--------------------------------
remove_methods_from_cmath.patch (7.89 KB)
deprecate_CMath_methods.patch (6.4 KB)


-- 
https://bugs.ruby-lang.org/