[ruby-core:68911] [Ruby trunk - Feature #11072] [PATCH] connect_nonblock(..., exception: false) does not raise EISCONN

Issue #11072 has been updated by Eric Wong.

Assignee changed from Akira Tanaka to Nobuyoshi Nakada

nobu/matz: any comment on just this patch? thanks.

akr: thanks for the comment, I will leave the second connect_nonblock call in socket.rb


----------------------------------------
Feature #11072: [PATCH] connect_nonblock(..., exception: false) does not raise EISCONN
https://bugs.ruby-lang.org/issues/11072#change-52176

* Author: Eric Wong
* Status: Open
* Priority: Normal
* Assignee: Nobuyoshi Nakada
----------------------------------------
This is to reduce exceptions for code which issues a (IMHO,
unnecessary) second connect() syscall.

I'll update ext/socket/lib/socket.rb to reduce exceptions on
:connect_timeout if this is accepted.

Personally, I never bother issuing a second connect() syscall
anymore and just catch the failures when calling
write/read/sendmsg/recvmsg/etc, but maybe we need to keep the
second connect() syscall in socket.rb for some odd systems...


---Files--------------------------------
0001-connect_nonblock-.-exception-false-does-not-raise-EI.patch (1.56 KB)


-- 
https://bugs.ruby-lang.org/