From: headius@...
Date: 2015-04-09T16:59:09+00:00
Subject: [ruby-core:68826] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

Issue #11045 has been updated by Charles Nutter.


Nobuyoshi Nakada wrote:
> Or we need a standard way to isolate this kind of tests.

That's not a bad idea, actually. I will split the Linux-specific regression part into a separate test. JRuby uses excludes to mask tests, so that will allow us to exclude the platform-specific one.

----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-52089

* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: trunk
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.

1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?

I propose that we just make the test skip non-alpha salt unconditionally.



-- 
https://bugs.ruby-lang.org/