[ruby-core:66419] Re: [ruby-trunk - Bug #10535] [Open] Potential uninitialized reference pipe_open() in io.c

From: Eric Wong <normalperson@...>
Date: 2014-11-22 21:56:23 UTC
List: ruby-core #66419
asmaloney@gmail.com wrote:
> IF !defined(HAVE_WORKING_FORK) and !defined(HAVE_SPAWNV), THEN argc
> and argv are declared. (lines 5938, 5939)
> Unless I'm missing something in the #if #else #endif fiesta, they
> don't seem to be initialized anywhere.

I concur. On the other hand, which platforms are affected by this
problem?  Any platform maintainers care to comment?  Maybe we can
drop the code :)

A side note: we'd be better off reimplementing pipe_open (and similar
functions) individually on a per-platform basis to avoid the ugly
CPP conditionals.

Right now, it's hard-to-read for every platform.  Of course, this split
requires much coordination between platform maintainers...

In This Thread

Prev Next