From: matthew@...
Date: 2014-11-12T21:21:52+00:00
Subject: [ruby-core:66235] [ruby-trunk - Feature #10501] [PATCH] insns.def (opt_succ): remove Time#succ optimization

Issue #10501 has been updated by Matthew Kerwin.


A timely request. Please note [this question on omniref][1] from a couple of days ago, regarding Time ranges (and the implicit use of Time#succ). It seems people aren't aware of the deprecation, and may be quite surprised to find the method missing. I'm not sure just how widespread its use, though.

[1]: https://www.omniref.com/ruby/2.1.3/symbols/Range#annotation=4052082

----------------------------------------
Feature #10501: [PATCH] insns.def (opt_succ): remove Time#succ optimization
https://bugs.ruby-lang.org/issues/10501#change-49920

* Author: Eric Wong
* Status: Open
* Priority: Normal
* Assignee: Eric Wong
* Category: core
* Target version: current: 2.2.0
----------------------------------------
~~~
Time#succ is a deprecated method and not frequently used, so this wastes
icache in vm_exec_core.  Using bloat-o-meter in the Linux kernel source
to shows a small reduction on my x86-64 system:

$ ~/linux/scripts/bloat-o-meter ruby.before ruby.after
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-57 (-57)
function                                     old     new   delta
vm_exec_core                               24216   24159     -57

There should be no problems, I'll commit in a day or two.
~~~


---Files--------------------------------
0001-insns.def-opt_succ-remove-Time-succ-optimization.patch (1.11 KB)


-- 
https://bugs.ruby-lang.org/