From: mail@...
Date: 2014-11-10T22:29:22+00:00
Subject: [ruby-core:66177] [ruby-trunk - Feature #10474] [PATCH 1/1] Refactoring math.c (Combined some macros into one macro)

Issue #10474 has been updated by gogo tanaka.


Hi, I just wanna check there is any problems? if so please feel free to ask me.

And if it seems good, I'm gonna update these three my patches.

[10225](https://bugs.ruby-lang.org/issues/10225)
[10255](https://bugs.ruby-lang.org/issues/10255)
[10323](https://bugs.ruby-lang.org/issues/10323)

note: I'm not in a hurry. take your time :)

----------------------------------------
Feature #10474: [PATCH 1/1] Refactoring math.c (Combined some macros into one macro)
https://bugs.ruby-lang.org/issues/10474#change-49876

* Author: gogo tanaka
* Status: Open
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
Hi, there.

We call `Need_Float` macro with `RFLOAT_VALUE` macro at the all time,
so we don't need to assign result of `rb_to_float(x)` to temporary variable.

This is main reason I combined these two macros into one macro called `Get_RFloat_Value` and 
removed `Need_Float2`.

I'm not sure the name `Get_RFloat_Value` is best.
If you have more preferable one, let me know and I'll fix patch :)

Thanks. gogo.

---Files--------------------------------
combine_some_macros_into_one_at_math.c.patch (7.19 KB)


-- 
https://bugs.ruby-lang.org/