From: Benoit Daloze via ruby-core <ruby-core@...>
Date: 2023-11-17T11:46:24+01:00
Subject: [ruby-core:115407] Re: Ruby 3.2.2 - rbconfig.rb's MAKEFILE_CONFIG

--===============9083850463780719853==
Content-Type: multipart/alternative; boundary="0000000000003014cf060a56db68"

--0000000000003014cf060a56db68
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

Where do you see such code,
https://github.com/ruby/ruby/blob/master/lib/mkmf.rb doesn't seem to have
it.

In any case, it's not a good idea to use `CONFIG` in `extconf.rb`, use
`RbConfig::CONFIG` instead (like everywhere else), that's always expanded.

Benoit

On Fri, Nov 17, 2023 at 2:48=E2=80=AFAM Jay Mav via ruby-core <
ruby-core@ml.ruby-lang.org> wrote:

> Hello Ruby Dev Team,
> With Ruby 3.2.2, gem install fails because in rbconfig.rb,
> MAKEFILE_CONFIG's $(target_os) is not expanded (whereas CONFIG's is
> expanded correctly).
>
> The inline doc in mkconfig.rb states that the caller can expand
> MAKEFILE_CONFIG's values by calling RbConfig::expand().
>
> However, ruby-shadow gem's Makefile generator -- extconf.rb -- does not
> call expand and directly uses mkmf.rb's CONFIG instance (which is
> RbConfig::MAKEFILE_CONFIG), because of which $(target_os) does not get
> expanded.
> This causes ruby-shadow gem install to fail with Ruby 3.2.2.
>
> Would the Ruby Dev Team accept the following proposal to fix mkconfig.rb,
> so that the generated rbconfig.rb instantiates MAKEFILE_CONFIG AFTER
> CONFIG's values have been expanded?
>
>   # Existing code...
>   CONFIG.each_value do |val|
>     RbConfig::expand(val)
>   end
>   # Move instantiation of MAKEFILE_CONFIG after expanding CONFIG's values=
.
>   MAKEFILE_CONFIG =3D {}
>   CONFIG.each{|k,v| MAKEFILE_CONFIG[k] =3D v.dup}
>
> If we fix it in mkconfig.rb, we can avoid callers having to explicitly
> call expand for MAKEFILE_CONFIG's values.
>
> Thanks.
>  ______________________________________________
>  ruby-core mailing list -- ruby-core@ml.ruby-lang.org
>  To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
>  ruby-core info --
> https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.=
org/

--0000000000003014cf060a56db68
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hello,</div><div><br></div><div>Where do you see such=
 code, <a href=3D"https://github.com/ruby/ruby/blob/master/lib/mkmf.rb">htt=
ps://github.com/ruby/ruby/blob/master/lib/mkmf.rb</a> doesn&#39;t seem to h=
ave it.</div><div><br></div><div>In any case, it&#39;s not a good idea to u=
se `CONFIG` in `extconf.rb`, use `RbConfig::CONFIG` instead (like everywher=
e else), that&#39;s always expanded.<br></div><div><br></div><div>Benoit<br=
></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail=
_attr">On Fri, Nov 17, 2023 at 2:48=E2=80=AFAM Jay Mav via ruby-core &lt;<a=
 href=3D"mailto:ruby-core@ml.ruby-lang.org">ruby-core@ml.ruby-lang.org</a>&=
gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0=
px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div =
dir=3D"ltr">Hello Ruby Dev Team,<br>With Ruby 3.2.2, gem install fails beca=
use in rbconfig.rb, MAKEFILE_CONFIG&#39;s $(target_os) is not expanded (whe=
reas CONFIG&#39;s is expanded correctly). <br><br>The inline doc in mkconfi=
g.rb states that the caller can expand MAKEFILE_CONFIG&#39;s values by call=
ing RbConfig::expand(). <br><br>However, ruby-shadow gem&#39;s Makefile gen=
erator -- extconf.rb -- does not call expand and directly uses mkmf.rb&#39;=
s CONFIG instance (which is RbConfig::MAKEFILE_CONFIG), because of which $(=
target_os) does not get expanded.<br>This causes ruby-shadow gem install to=
 fail with Ruby 3.2.2.<br><br>Would the Ruby Dev Team accept the following =
proposal to fix mkconfig.rb, so that the generated rbconfig.rb instantiates=
 MAKEFILE_CONFIG AFTER CONFIG&#39;s values have been expanded?<br><br>=C2=
=A0 # Existing code...<br>=C2=A0 CONFIG.each_value do |val|<br>=C2=A0 =C2=
=A0 RbConfig::expand(val)<br>=C2=A0 end<br>=C2=A0 # Move instantiation of M=
AKEFILE_CONFIG after expanding CONFIG&#39;s values.<br>=C2=A0 MAKEFILE_CONF=
IG =3D {}<br>=C2=A0 CONFIG.each{|k,v| MAKEFILE_CONFIG[k] =3D v.dup}<br><br>=
If we fix it in mkconfig.rb, we can avoid callers having to explicitly call=
 expand for MAKEFILE_CONFIG&#39;s values.<br><br>Thanks.<br></div>
=C2=A0______________________________________________<br>
=C2=A0ruby-core mailing list -- <a href=3D"mailto:ruby-core@ml.ruby-lang.or=
g" target=3D"_blank">ruby-core@ml.ruby-lang.org</a><br>
=C2=A0To unsubscribe send an email to <a href=3D"mailto:ruby-core-leave@ml.=
ruby-lang.org" target=3D"_blank">ruby-core-leave@ml.ruby-lang.org</a><br>
=C2=A0ruby-core info -- <a href=3D"https://ml.ruby-lang.org/mailman3/postor=
ius/lists/ruby-core.ml.ruby-lang.org/" rel=3D"noreferrer" target=3D"_blank"=
>https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.o=
rg/</a></blockquote></div>

--0000000000003014cf060a56db68--

--===============9083850463780719853==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
--===============9083850463780719853==--