[#118346] [Ruby master Bug#20586] Some filesystem calls in dir.c are missing error handling and can return incorrect results if interrupted — "ivoanjo (Ivo Anjo) via ruby-core" <ruby-core@...>
Issue #20586 has been reported by ivoanjo (Ivo Anjo).
13 messages
2024/06/19
[ruby-core:118209] [Ruby master Feature#19998] Emit deprecation warnings when the old (non-Typed) Data_XXX API is used
From:
"byroot (Jean Boussier) via ruby-core" <ruby-core@...>
Date:
2024-06-06 09:42:38 UTC
List:
ruby-core #118209
Issue #19998 has been updated by byroot (Jean Boussier). > Whether it is actually possible to remove the APIs may require careful consideration in the future. Agreed. I'm not suggesting that yet. However I do have a proof of concept that degrades a bit the old API performance in favor of improving the new API performance, so having the API explicitly marked as deprecated help justify this kind of changes. ---------------------------------------- Feature #19998: Emit deprecation warnings when the old (non-Typed) Data_XXX API is used https://bugs.ruby-lang.org/issues/19998#change-108696 * Author: byroot (Jean Boussier) * Status: Open ---------------------------------------- The replacement API was introduced in Ruby 1.9.2 (2010) [Feature #3064], and the old untyped data API was marked a deprecated in the documentation as of Ruby 2.3.0 (2015): https://github.com/ruby/ruby/commit/98544c372d948717de22afc86d162e411f1fb5f1 However, as of today, no deprecation warning of any sort is emitted when the API is used. Ultimately removing the old untyped API would allow to easily reclaim 8B on every `T_DATA` which could be used by the newly introduced embedded TypedData objects https://github.com/ruby/ruby/pull/7440 Was there any discussions about removing the old API at some point? Could we emit a warning when the API is used? Either verbose or non-verbose, to at least surface the issue to gem owners? This would help drive the effort to fix outdated gems, allowing to eventually remove this old API in the future. Looking at our big applications dependencies, there seem to be a small minority of gems still using the old API: - https://rubygems.org/gems/unf_ext (https://github.com/knu/ruby-unf_ext/pull/72) - https://rubygems.org/gems/rotoscope (https://github.com/Shopify/rotoscope/pull/99) - https://rubygems.org/gems/re2 (https://github.com/mudge/re2/pull/116) - ~~https://rubygems.org/gems/mysql2~~ (use either API to support old rubies) Migrating them over doesn't seem too hard. -- https://bugs.ruby-lang.org/