From: "Eregon (Benoit Daloze) via ruby-core" Date: 2023-07-18T10:12:18+00:00 Subject: [ruby-core:114228] [Ruby master Misc#19772] API naming for YARP compiler Issue #19772 has been updated by Eregon (Benoit Daloze). FWIW I don't think renaming YARP at this point makes sense, now that the `yarp` gem [is owned](https://rubygems.org/gems/yarp) by @kddnewton and after the [detailed blog post](https://railsatscale.com/2023-06-12-rewriting-the-ruby-parser/). Everyone calls it YARP, renaming now would feel silly. If/when YARP would become the default then it would just be `RubyVM::InstructionSequence.compile`. So I think option 2 is the best and makes it easy to experiment with a different default. The implementation should be part of `compile.c`, so IMO it also makes sense the API is under `RubyVM` and not `YARP`. ---------------------------------------- Misc #19772: API naming for YARP compiler https://bugs.ruby-lang.org/issues/19772#change-103915 * Author: jemmai (Jemma Issroff) * Status: Open * Priority: Normal ---------------------------------------- We are working on the YARP compiler, and have [the first PR ready](https://github.com/ruby/ruby/pull/8042) which introduces the YARP compile method. Our only outstanding question before merging it is about naming. How should we expose the public API for YARP's compile method? Potential suggestions: 1. YARP.compile 2. RubyVM::InstructionSequence.compile(yarp: true) 3. RubyVM::InstructionSequence.compile_yarp 4. Any of the above options, with a name other than yarp (please suggest an alternative) Regarding option 1, which would mirror `YARP.parse`, is the top level constant `YARP` acceptable? cc @matz @ko1 -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/