[ruby-core:114395] [Ruby master Misc#19772] API naming for YARP compiler
From:
"jemmai (Jemma Issroff) via ruby-core" <ruby-core@...>
Date:
2023-08-17 17:21:58 UTC
List:
ruby-core #114395
Issue #19772 has been updated by jemmai (Jemma Issroff). nobu (Nobuyoshi Nakada) wrote in #note-5: > I don't think "YA-" names nice in general, unless for development code name. Agreed with you that `"YA-"` prefix is overloaded. Is your preference then something like `YARP.parse.compile` (or a different name)? > As for `YARP.compile`, "a parser compiles code" sounds strange a little to me. > It might be better that `YARP.parse` will return AST and the AST has `compile` method to return ISeq. I have added this topic to the dev meeting agenda and hope we can resolve it there. ---------------------------------------- Misc #19772: API naming for YARP compiler https://bugs.ruby-lang.org/issues/19772#change-104144 * Author: jemmai (Jemma Issroff) * Status: Open * Priority: Normal ---------------------------------------- We are working on the YARP compiler, and have [the first PR ready](https://github.com/ruby/ruby/pull/8042) which introduces the YARP compile method. Our only outstanding question before merging it is about naming. How should we expose the public API for YARP's compile method? Potential suggestions: 1. YARP.compile 2. RubyVM::InstructionSequence.compile(yarp: true) 3. RubyVM::InstructionSequence.compile_yarp 4. Any of the above options, with a name other than yarp (please suggest an alternative) Regarding option 1, which would mirror `YARP.parse`, is the top level constant `YARP` acceptable? cc @matz @ko1 -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/