From: "nagachika (Tomoyuki Chikanaga) via ruby-core" <ruby-core@...>
Date: 2023-07-17T08:26:55+00:00
Subject: [ruby-core:114214] [Ruby master Bug#19455] Ruby 3.2: wrong Regexp encoding with non-ASCII comments

Issue #19455 has been updated by nagachika (Tomoyuki Chikanaga).



Backport changed from 3.0: DONTNEED, 3.1: DONTNEED, 3.2: REQUIRED to 3.0: DONTNEED, 3.1: DONTNEED, 3.2: DONE



ruby_3_2 be09d77b966c7bcc77957927f16cefe66b365495 merged revision(s) a8ba1ddd78544b4bda749051d44f7b2a8a0ec5ff.



----------------------------------------

Bug #19455: Ruby 3.2: wrong Regexp encoding with non-ASCII comments

https://bugs.ruby-lang.org/issues/19455#change-103901



* Author: janosch-x (Janosch M�ller)

* Status: Closed

* Priority: Normal

* ruby -v: ruby 3.2.0 (2022-12-25 revision a528908271)

* Backport: 3.0: DONTNEED, 3.1: DONTNEED, 3.2: DONE

----------------------------------------

comments and comment groups don't trigger the correct `Regexp#encoding` on Ruby 3.2 anymore:



```ruby

# ruby 3.1

/#a/x.encoding          # => #<Encoding:US-ASCII> # OK

/(?#a)/.encoding        # => #<Encoding:US-ASCII> # OK

/#�/x.encoding          # => #<Encoding:UTF-8>    # OK

/(?#�)/.encoding        # => #<Encoding:UTF-8>    # OK



# ruby 3.2

/#a/x.encoding          # => #<Encoding:US-ASCII> # OK

/(?#a)/.encoding        # => #<Encoding:US-ASCII> # OK

/#�/x.encoding          # => #<Encoding:US-ASCII> # BUG

/(?#�)/.encoding        # => #<Encoding:US-ASCII> # BUG



/#�/x.inspect           # => "/#\\xC3\\xBC/x"

/(?#�)/.inspect         # => "/(?#\\xC3\\xBC)/"



# bug is hidden if there are non-ascii chars outside comments

/�#�/x.encoding         # => #<Encoding:UTF-8>

/�(?#�)/.encoding       # => #<Encoding:UTF-8>

```



i think these changes might be the cause: https://github.com/ruby/ruby/commit/ec3542229b29ec93062e9d90e877ea29d3c19472#diff-c3675fa319803b2f5a775defa40694edb9a761baa3a54fa78e1fdef8f918cc7cR2837-R2890



@jeremyevans0 JFYI







-- 

https://bugs.ruby-lang.org/

 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/