From: "mame (Yusuke Endoh) via ruby-core" <ruby-core@...>
Date: 2023-07-14T19:09:02+00:00
Subject: [ruby-core:114192] [Ruby master Bug#19749] Confirm correct behaviour when attaching private method with `#define_method`

Issue #19749 has been updated by mame (Yusuke Endoh).


@jeremyevans0 Thanks, so the question is whether visibility should be updated when redefining a method by `define_method` with the method itself.

```ruby
class C
  def foo; end

  private

  define_method(:foo, method(:foo))
  # current: the method foo is kept public
  # expected: the method foo is changed private
end
```

@matz What do you think?

----------------------------------------
Bug #19749: Confirm correct behaviour when attaching private method with `#define_method`
https://bugs.ruby-lang.org/issues/19749#change-103879

* Author: itarato (Peter Arato)
* Status: Open
* Priority: Normal
* ruby -v: 3.3.0
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN
----------------------------------------
This issue is a special case of https://bugs.ruby-lang.org/issues/19745:

Should dynamically added private methods via `.singleton_class.send(:define_method,...` at the top-level be accessible publicly?

See the following example:

```ruby
def bar; end

foo = Object.new
foo.singleton_class.define_method(:bar, method(:bar))

foo.bar # No error.
```

The script above runs fine on latest Ruby 3.3. Is this correct to ignore the fact that the visibility in the caller context is the default top-level private visibility?

This came up during a TruffleRuby investigation (https://github.com/oracle/truffleruby/issues/3134) where the result for the same script is: `private method 'bar' called for #<Object:0xc8> (NoMethodError)`




-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/