[ruby-core:108743] [Ruby master Bug#18779] `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms.

Issue #18779 has been updated by byroot (Jean Boussier).


@jaruga no, I requested it, but it's the release manager of each branch that is supposed to do the backport.

These two commits are on master. The backported commits will likely be widely different as there was many changes in compaction APIs between 3.0 and master.

----------------------------------------
Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms. 
https://bugs.ruby-lang.org/issues/18779#change-97803

* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: WONTFIX, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
I received several bug report on native gems using `GC.verify_compaction_references` in their test suite.

Examples:

  - https://github.com/msgpack/msgpack-ruby/pull/275/files
  - https://github.com/Shopify/bootsnap/pull/414/files

I think that when `!GC_COMPACTION_SUPPORTED`, rather than raise `NotImplementedError`, we should instead define these methods as `rb_f_notimplement` like `Process.fork` on Windows.

This way `GC.respond_to?(:compact)` would be a proper way to test for compaction support.

Unfortunately, these methods are defined through `.rb` files with `Primitive`, and I don't know wether it's possible to check `GC_COMPACTION_SUPPORTED` from there, nor if it's possible to define a `rb_f_notimplement` method.

cc @tenderlovemaking 



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>