[ruby-core:110014] [Ruby master Bug#18784] `FileUtils.rm_f` and `FileUtils.rm_rf` should not mask exceptions
From:
"mame (Yusuke Endoh)" <noreply@...>
Date:
2022-09-22 23:14:21 UTC
List:
ruby-core #110014
SXNzdWUgIzE4Nzg0IGhhcyBiZWVuIHVwZGF0ZWQgYnkgbWFtZSAoWXVzdWtlIEVuZG9oKS4NCg0K DQpXZSBkaXNjdXNzZWQgdGhlIGlzc3VlIGF0IHRoZSBkZXYgbWVldGluZyAoZm9yIHZlcnkgbG9u ZyB0aW1lKSBhbmQgYWdyZWVkIHRvIHJldmVydCBpdCBvbmNlLg0KDQpUaGVyZSBhcmUgdHdvIHBv c3NpYmxlIHVzZSBjYXNlcyBmb3IgYEZpbGVVdGlscy5ybV9yZmA6ICgxKSBkZWxldGUgdGhlIHRh cmdldCBhdCBhbGwgY29zdHMsIGFuZCAoMikgd2FudCB0byBkZWxldGUgdGhlIHRhcmdldCBpZiBw b3NzaWJsZS4NCg0KRm9yICgxKSwgaXQgaXMgbm90IHN1ZmZpY2llbnQgdG8gcmFpc2UgYW4gZXhj ZXB0aW9uIHdoZW4gaXQgZmFpbHMgdG8gZGVsZXRlIHNvbWUgZmlsZXMuIEluc3RlYWQsIHlvdSBo YXZlIHRvIG1ha2UgYW4gZWZmb3J0IHRvIGRlbGV0ZSB0aGUgdGFyZ2V0IGJ5IHVzaW5nIGBjaG1v ZGAgYW5kL29yIHNsZWVwL3JldHJ5LiBUaGlzIGlzIG9idmlvdXNseSB0b28gaW5jb21wYXRpYmxl IHRvIHRoZSBvcmlnaW5hbCBgRmlsZVV0aWxzLnJtX3JmYC4gU28gdGhlIHVzZXJzIHNob3VsZCB3 cml0ZSB0aGVpciBvd24gY29kZSB0byBkZWxldGUgdGhlIGRpcmVjdG9yeSwgb3Igd2Ugc2hvdWxk IHByb3ZpZGUgYW5vdGhlciBtZXRob2QgbGlrZSBgRmlsZVV0aWxzLnN1cGVyX3JtX3JmYCAodGVu dGF0aXZlIG5hbWUgOi0pIGZvciB0aGF0LCBpZiB0aGlzIHVzZSBjYXNlIGlzIHNvIGNvbW1vbi4N Cg0KRm9yICgyKSwgdGhlIG9yaWdpbmFsIGJlaGF2aW9yIHRoYXQgc3dhbGxvd3MgdGhlIGZhaWx1 cmUgaXMgZ29vZCBlbm91Z2guIFdlIGNvbnNpZGVyZWQgdGhhdCB0aGlzIHVzZSBjYXNlIGlzIG1v cmUgY29tbW9uIHRoYW4gKDEpLiBGb3IgZXhhbXBsZSwgd2Ugb2Z0ZW4gdXNlIGBybV9yZmAgdG8g ZGVsZXRlIGEgdGVtcG9yYWwgZGlyZWN0b3J5IGNyZWF0ZWQgdW5kZXIgdG1wLy4gSW4gdGhpcyBj YXNlLCBpdCBpcyBub3QgYSBiaWcgZGVhbCBldmVuIGlmIGBybV9yZmAgZmFpbGVkIHRvIGRlbGV0 ZSB0aGUgZGlyZWN0b3J5LiBXZSdkIGxpa2UgdG8gbGVhdmUgdGhlIE9TIHRvIGRlbGV0ZSB0aGUg ZGlyZWN0b3J5IGV2ZW50dWFsbHkgKHN1Y2ggYXMgb24gcmVzdGFydGluZyB0aGUgT1MpLg0KDQpJ dCBpcyBwb3NzaWJsZSB0byBpbnRyb2R1Y2UgYEZpbGVVdGlscy5zdHJpY3Rfcm1fcmZgIHdoaWNo IHRocm93cyBhbiBleGNlcHRpb24gb24gZmFpbHVyZS4gQnV0IGl0IGRvZXMgbm90IG1lZXQgdXNl IGNhc2VzICgxKSBhbmQgKDIpLiBXZSBuZWVkIHRvIGNsYXJpZnkgdGhlIGJlbmVmaXQgb2YgdGhl IG1ldGhvZCBpZiB3ZSBpbnRyb2R1Y2UgaXQuIEFsc28sIHdlIG5lZWQgYSBiZXR0ZXIgbmFtZS4g KGBzdHJpY3RgIGlzIG5vdCBjbGVhci4pDQoNCldlIGRpZG4ndCBoYXZlIGVub3VnaCB0aW1lIHRv IGRpc2N1c3MgYW5kIGFncmVlIG9uIHByaW50aW5nIGEgd2FybmluZyBpbiBjYXNlIG9mIGZhaWx1 cmUgdW5kZXIgVkVSQk9TRSBtb2RlLg0KDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tDQpCdWcgIzE4Nzg0OiBgRmlsZVV0aWxzLnJtX2ZgIGFuZCBgRmlsZVV0aWxzLnJt X3JmYCBzaG91bGQgbm90IG1hc2sgZXhjZXB0aW9ucw0KaHR0cHM6Ly9idWdzLnJ1YnktbGFuZy5v cmcvaXNzdWVzLzE4Nzg0I2NoYW5nZS05OTI2NQ0KDQoqIEF1dGhvcjogZGVpdmlkIChEYXZpZCBS b2Ryw61ndWV6KQ0KKiBTdGF0dXM6IE9wZW4NCiogUHJpb3JpdHk6IE5vcm1hbA0KKiBBc3NpZ25l ZTogbWFtZSAoWXVzdWtlIEVuZG9oKQ0KKiBydWJ5IC12OiBydWJ5IDMuMS4ycDIwICgyMDIyLTA0 LTEyIHJldmlzaW9uIDQ0OTFiYjc0MGEpIFthcm02NC1kYXJ3aW4yMV0NCiogQmFja3BvcnQ6IDIu NzogVU5LTk9XTiwgMy4wOiBVTktOT1dOLCAzLjE6IFVOS05PV04NCi0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCkluIHJlY2VudCB0aW1lcywgSSd2ZSBiZWVuIGhhdmlu ZyBpc3N1ZXMgd2l0aCB0aGVzZSBtZXRob2RzIGJlY2F1c2UgdGhleSBkb24ndCBsZXQgeW91IGtu b3cgd2hlbiBzb21lIGlzc3VlIGhhcHBlbmVkIHdoaWxlIHRyeWluZyB0byByZW1vdmUgdGhlIGdp dmVuIGZvbGRlcnMvZmlsZXMuDQoNCklNTyBtb3N0IHVzZXJzIGV4cGVjdCBhbGwgcHJlLWV4aXN0 aW5nIGZvbGRlcnMvZmlsZXMgdGhhdCBhcmUgcGFzc2VkIHRvIHRoZXNlIG1ldGhvZHMgdG8gYmUg YWN0dWFsbHkgcmVtb3ZlZCBieSB0aGUgbWV0aG9kcy4gSW5zdGVhZCwgd2hlbiB0aGlzIGhhcHBl bnMsIGVycm9ycyBhcmUgc2lsZW50bHkgc3dhbGxvd2VkIGFuZCBub3JtYWxseSB0aGUgcmVzdWx0 IGlzIHRoYXQgeW91IHdpbGwgZ2V0IHNvbWUgb3RoZXIgaXNzdWUgZnVydGhlciBkb3duIHRoZSBy b2FkLCBtYWtpbmcgdGhlIHByb2JsZW0gaGFyZCB0byBkZWJ1Zy4NCg0KVGhlIGN1cnJlbnQgd29y a2Fyb3VuZCBJJ20gdXNpbmcgaXMgdG8gZG91YmxlIGNoZWNrIHdoZXRoZXIgdGhlIGZpbGVzIHN0 aWxsIGV4aXN0IGFmdGVyIHRoZSBtZXRob2QsIGFuZCByYWlzZSBhIGN1c3RvbSBlcnJvciBpZiB0 aGV5IGRvLCBidXQgSSBzdGlsbCBjYW4ndCBzZWUgdGhlIG9yaWdpbmFsIHByb2JsZW0sIHNvIGlz c3VlcyBhcmUgc2ltaWxhcmx5IGhhcmQgdG8gZGVidWcuDQoNClRoaXMgaXMgYWxzbyBhIGRldmlh dGlvbiBmcm9tIGhvdyBgcm0gLXJmYCBhbmQgYHJtIC1mYCB3b3JrLCBzaW5jZSB0aGVzZSB0b29s cyBmaW5pc2ggd2l0aCBhIGZhaWx1cmUgZXhpdCBjb2RlIHdoZW4gdGhleSBmYWlsIHRvIHJlbW92 ZSB0aGUgZ2l2ZW4gZmlsZXMuIEdpdmVuIHRoYXQgYGZpbGV1dGlsc2AgaXMgaW50ZW5kZWQgdG8g bWltaWMgc2hlbGwgZnVuY3Rpb25hbGl0eSwgSSB0aGluayB0aGlzIGlzIGp1c3QgYSBidWcuDQoN CkkgdGhpbmsgdGhlIGludGVudGlvbiBvZiB0aGUgYGZvcmNlYCBmbGFnIGhlcmUgaXMgdG86DQoq IERvbid0IHByb21wdCBmb3IgY29uZmlybWF0aW9uLg0KKiBJZ25vcmUgZ2l2ZW4gYXJndW1lbnRz IHRoYXQgYXJlIG5vdCBmaWxlcyB0aGF0IGFscmVhZHkgZXhpc3QuDQoNCkJ1dCBhbnkgaXNzdWUg b3RoZXIgdGhhbiB0aGF0IHNob3VsZCBub3QgYmUgc3dhbGxvd2VkLCBhbmQgaW4gZ2VuZXJhbCBJ IHRoaW5rIHRoZSBtZXRob2Qgc2hvdWxkIHN1Y2NlZWQgaWYgYW5kIG9ubHkgaWYgdGhlIGdpdmVu IGxpc3Qgb2YgZmlsZSBuYW1lcyBkb2VzIG5vdCBleGlzdCBhZnRlciB0aGUgbWV0aG9kcyBhcmUg ZG9uZS4NCg0KSSB0aGluayB0aGlzIGlzIGluIGxpbmUgd2l0aCB0aGUgZm9sbG93aW5nIG5vdGUg SSBnZXQgd2hlbiBJIHJ1biBgbWFuIHJtYCwgYnV0IGFsc28gc3VnZ2VzdHMgdGhhdCB0aGlzIGlz IG5vdCB0aGUgc3RhbmRhcmQgYmVoYXZpb3Igb2YgImhpc3RvcmljYWwgaW1wbGVtZW50YXRpb25z Ig0KDQo+IENPTVBBVElCSUxJVFkNCj4NCj4gVGhlIHJtIHV0aWxpdHkgZGlmZmVycyBmcm9tIGhp c3RvcmljYWwgaW1wbGVtZW50YXRpb25zIGluIHRoYXQgdGhlIC1mIG9wdGlvbiBvbmx5IG1hc2tz IGF0dGVtcHRzIHRvIHJlbW92ZSBub24tZXhpc3RlbnQgZmlsZXMgaW5zdGVhZCBvZiBtYXNraW5n IGEgbGFyZ2UgdmFyaWV0eSBvZiBlcnJvcnMuDQoNCkkgaW1wbGVtZW50ZWQgdGhpcyBhdCBodHRw czovL2dpdGh1Yi5jb20vcnVieS9maWxldXRpbHMvcHVsbC81OCwgYnV0IHRyZWF0aW5nIHRoaXMg YXMgYSBidWcuIEkgY2FuIGFsc28gaW1wbGVtZW50IGEgbW9yZSBjb25zZXJ2YXRpdmUgZm9yIGFw cHJvYWNoIGZvciB1c2VycyB0aGF0IG1pZ2h0IGJlIHVzaW5nIGBGaWxlVXRpbHMucm1fcmZgIG9y IGBGaWxlVXRpbHMucm1fZmAgYnV0IGRvbid0IHJlYWxseSBjYXJlIGlmIHRoZSBmaWxlcyBhcmUg cmVtb3ZlZCBvciBub3QuDQoNCkFsdGVybmF0aXZlIHByb3Bvc2FscyB3b3VsZCBiZSBgRmlsZVV0 aWxzLnJtX3JmKGZvcmNlOiBzdHJpY3QpYCwgb3IgYEZpbGVVdGlscy5zdHJpY3Rfcm1fcmZgLCBi dXQgdG8gYmUgaG9uZXN0LCBpZiB0aGlzIGlzIGNvbnNpZGVyZWQgYSBicmVha2luZyBjaGFuZ2Us IEkgd291bGQgc2hpcCBpdCBhcyBhIG5ldyBtYWpvciB2ZXJzaW9uLCBhbmQgbGV0IHVzZXJzIHVw ZGF0ZSB0aGVpciBjb2RlIHRvIHN3YWxsb3cgZXJyb3JzIHRoZW1zZWx2ZXMgaWYgdGhleSBuZWVk IHRvLg0KDQpIYXBweSB0byBoZWFyIGFueSBmZWVkYmFjayENCg0KDQoNCi0tIA0KaHR0cHM6Ly9i dWdzLnJ1YnktbGFuZy5vcmcvDQoKVW5zdWJzY3JpYmU6IDxtYWlsdG86cnVieS1jb3JlLXJlcXVl c3RAcnVieS1sYW5nLm9yZz9zdWJqZWN0PXVuc3Vic2NyaWJlPgo8aHR0cDovL2xpc3RzLnJ1Ynkt bGFuZy5vcmcvY2dpLWJpbi9tYWlsbWFuL29wdGlvbnMvcnVieS1jb3JlPgo=