[#118346] [Ruby master Bug#20586] Some filesystem calls in dir.c are missing error handling and can return incorrect results if interrupted — "ivoanjo (Ivo Anjo) via ruby-core" <ruby-core@...>
Issue #20586 has been reported by ivoanjo (Ivo Anjo).
13 messages
2024/06/19
[ruby-core:118234] [Ruby master Feature#18773] deconstruct to receive a range
From:
"kddnewton (Kevin Newton) via ruby-core" <ruby-core@...>
Date:
2024-06-07 13:51:25 UTC
List:
ruby-core #118234
Issue #18773 has been updated by kddnewton (Kevin Newton).
Status changed from Assigned to Rejected
Going to close this, as I think it should be fixed in other ways.
----------------------------------------
Feature #18773: deconstruct to receive a range
https://bugs.ruby-lang.org/issues/18773#change-108733
* Author: kddnewton (Kevin Newton)
* Status: Rejected
* Assignee: ktsj (Kazuki Tsujimoto)
----------------------------------------
Currently when you're pattern matching against a hash pattern, `deconstruct_keys` receives the keys that are being matched. This is really useful for computing expensive hashes.
However, when you're pattern matching against an array pattern, you don't receive any information. So if the array is expensive to compute (for instance loading an array of database records), you have no way to bail out. It would be useful to receive a range signifying how many records the pattern is specifying. It would be used like the following:
```ruby
class ActiveRecord::Relation
def deconstruct(range)
(loaded? || range.cover?(count)) ? records : nil
end
end
```
It needs to be a range and not just a number to handle cases where `*` is used. You would use it like:
```ruby
case Person.all
in []
"No records"
in [person]
"Only #{person.name}"
else
"Multiple people"
end
```
In this way, you wouldn't have to load the whole thing into memory to check if it pattern matched. The patch is here: https://github.com/ruby/ruby/pull/5905.
--
https://bugs.ruby-lang.org/